Re: [PATCH] physmem: allow debug writes to MMIO regions

2024-05-31 Thread Peter Maydell
On Mon, 20 May 2024 at 19:48, Perry Hung wrote: > > Philippe, Peter, > > Thank you for the comments. I am not even sure what the semantics of > putting a breakpoint or watchpoint > on device regions are supposed to be. I would imagine it is > architecture-specific as to whether this is even allowe

Re: [PATCH] physmem: allow debug writes to MMIO regions

2024-05-20 Thread Perry Hung
Philippe, Peter, Thank you for the comments. I am not even sure what the semantics of putting a breakpoint or watchpoint on device regions are supposed to be. I would imagine it is architecture-specific as to whether this is even allowed. It appears for example, that armv8-a allows watchpoint

Re: [PATCH] physmem: allow debug writes to MMIO regions

2024-05-20 Thread Peter Maydell
On Wed, 15 May 2024 at 13:49, Philippe Mathieu-Daudé wrote: > > Hi Perry, > > On 14/5/24 01:33, Perry Hung wrote: > > Writes from GDB to memory-mapped IO regions are currently silently > > dropped. cpu_memory_rw_debug() calls address_space_write_rom(), which > > calls address_space_write_rom_inter

Re: [PATCH] physmem: allow debug writes to MMIO regions

2024-05-15 Thread Philippe Mathieu-Daudé
Hi Perry, On 14/5/24 01:33, Perry Hung wrote: Writes from GDB to memory-mapped IO regions are currently silently dropped. cpu_memory_rw_debug() calls address_space_write_rom(), which calls address_space_write_rom_internal(), which ignores all non-ram/rom regions. Add a check for MMIO regions an

[PATCH] physmem: allow debug writes to MMIO regions

2024-05-13 Thread Perry Hung
Writes from GDB to memory-mapped IO regions are currently silently dropped. cpu_memory_rw_debug() calls address_space_write_rom(), which calls address_space_write_rom_internal(), which ignores all non-ram/rom regions. Add a check for MMIO regions and direct those to address_space_rw() instead. Re