Re: [PATCH] pc: fix leak in pc_system_flash_cleanup_unused

2020-07-01 Thread Paolo Bonzini
On 01/07/20 15:06, Alexander Bulekov wrote: >> Yes; you can also add it in pc_pflash_create, because >> >> /* >> * Since object_property_add_child added a reference to the child object, >> * we can drop the reference added by object_initialize(), so the child >> * property will o

Re: [PATCH] pc: fix leak in pc_system_flash_cleanup_unused

2020-07-01 Thread Alexander Bulekov
On 200701 0749, Paolo Bonzini wrote: > On 01/07/20 03:58, Alexander Bulekov wrote: > > fix a leak detected when building with --enable-sanitizers: > > ./i386-softmmu/qemu-system-i386 > > Upon exit: > > ==13576==ERROR: LeakSanitizer: detected memory leaks > > > > Direct leak of 1216 byte(s) in 1 ob

Re: [PATCH] pc: fix leak in pc_system_flash_cleanup_unused

2020-07-01 Thread Philippe Mathieu-Daudé
On 7/1/20 3:58 AM, Alexander Bulekov wrote: > fix a leak detected when building with --enable-sanitizers: > ./i386-softmmu/qemu-system-i386 > Upon exit: > ==13576==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 1216 byte(s) in 1 object(s) allocated from: > #0 0x7f9d2ed5c628 in

Re: [PATCH] pc: fix leak in pc_system_flash_cleanup_unused

2020-06-30 Thread Paolo Bonzini
On 01/07/20 03:58, Alexander Bulekov wrote: > fix a leak detected when building with --enable-sanitizers: > ./i386-softmmu/qemu-system-i386 > Upon exit: > ==13576==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 1216 byte(s) in 1 object(s) allocated from: > #0 0x7f9d2ed5c628 in

[PATCH] pc: fix leak in pc_system_flash_cleanup_unused

2020-06-30 Thread Alexander Bulekov
fix a leak detected when building with --enable-sanitizers: ./i386-softmmu/qemu-system-i386 Upon exit: ==13576==ERROR: LeakSanitizer: detected memory leaks Direct leak of 1216 byte(s) in 1 object(s) allocated from: #0 0x7f9d2ed5c628 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5) #1 0x7