Re: [PATCH] net: remove qemu_ether_ntoa()

2021-02-26 Thread Doug Evans
On Fri, Feb 26, 2021 at 4:06 AM wrote: > From: Marc-André Lureau > > The function is not thread-safe and sets a bad example. It's used in a > single place for tracing, so open-code the format string like other > trace events with MAC addresses. > > Cc: qemu-triv...@nongnu.org > Signed-off-by: Ma

Re: [PATCH] net: remove qemu_ether_ntoa()

2021-02-26 Thread Philippe Mathieu-Daudé
On 2/26/21 1:06 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The function is not thread-safe and sets a bad example. It's used in a > single place for tracing, so open-code the format string like other > trace events with MAC addresses. > > Cc: qemu-triv...@nongnu.org > S

[PATCH] net: remove qemu_ether_ntoa()

2021-02-26 Thread marcandre . lureau
From: Marc-André Lureau The function is not thread-safe and sets a bad example. It's used in a single place for tracing, so open-code the format string like other trace events with MAC addresses. Cc: qemu-triv...@nongnu.org Signed-off-by: Marc-André Lureau --- include/qemu-common.h | 1 - net