Re: [PATCH] net: improve error message for missing netdev backend

2022-10-27 Thread Jason Wang
On Thu, Oct 27, 2022 at 6:52 PM Daniel P. Berrangé wrote: > > ping: Jason, are you willing to queue this since it has two > positive reviews. > Yes, I've queued this. Thanks > On Mon, Oct 03, 2022 at 11:06:12AM +0100, Daniel P. Berrangé wrote: > > The current message when using '-net user...' w

Re: [PATCH] net: improve error message for missing netdev backend

2022-10-27 Thread Daniel P . Berrangé
ping: Jason, are you willing to queue this since it has two positive reviews. On Mon, Oct 03, 2022 at 11:06:12AM +0100, Daniel P. Berrangé wrote: > The current message when using '-net user...' with SLIRP disabled at > compile time is: > > qemu-system-x86_64: -net user: Parameter 'type' expects

Re: [PATCH] net: improve error message for missing netdev backend

2022-10-04 Thread Thomas Huth
On 03/10/2022 12.06, Daniel P. Berrangé wrote: The current message when using '-net user...' with SLIRP disabled at compile time is: qemu-system-x86_64: -net user: Parameter 'type' expects a net backend type (maybe it is not compiled into this binary) An observation is that we're using the

Re: [PATCH] net: improve error message for missing netdev backend

2022-10-03 Thread Christian Schoenebeck
On Montag, 3. Oktober 2022 14:50:04 CEST Daniel P. Berrangé wrote: > On Mon, Oct 03, 2022 at 02:46:04PM +0200, Christian Schoenebeck wrote: > > On Montag, 3. Oktober 2022 12:06:12 CEST Daniel P. Berrangé wrote: > > > The current message when using '-net user...' with SLIRP disabled at > > > > > >

Re: [PATCH] net: improve error message for missing netdev backend

2022-10-03 Thread Daniel P . Berrangé
On Mon, Oct 03, 2022 at 02:46:04PM +0200, Christian Schoenebeck wrote: > On Montag, 3. Oktober 2022 12:06:12 CEST Daniel P. Berrangé wrote: > > The current message when using '-net user...' with SLIRP disabled at > > compile time is: > > > > qemu-system-x86_64: -net user: Parameter 'type' expect

Re: [PATCH] net: improve error message for missing netdev backend

2022-10-03 Thread Christian Schoenebeck
On Montag, 3. Oktober 2022 12:06:12 CEST Daniel P. Berrangé wrote: > The current message when using '-net user...' with SLIRP disabled at > compile time is: > > qemu-system-x86_64: -net user: Parameter 'type' expects a net backend type > (maybe it is not compiled into this binary) Is this inten

Re: [PATCH] net: improve error message for missing netdev backend

2022-10-03 Thread Marc-André Lureau
Hi On Mon, Oct 3, 2022 at 2:06 PM Daniel P. Berrangé wrote: > > The current message when using '-net user...' with SLIRP disabled at > compile time is: > > qemu-system-x86_64: -net user: Parameter 'type' expects a net backend type > (maybe it is not compiled into this binary) > > An observatio

[PATCH] net: improve error message for missing netdev backend

2022-10-03 Thread Daniel P . Berrangé
The current message when using '-net user...' with SLIRP disabled at compile time is: qemu-system-x86_64: -net user: Parameter 'type' expects a net backend type (maybe it is not compiled into this binary) An observation is that we're using the 'netdev->type' field here which is an enum value,