Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-07-05 Thread Dr. David Alan Gilbert
* Ilya Leoshkevich (i...@linux.ibm.com) wrote: > On Tue, 2022-07-05 at 16:27 +0100, Dr. David Alan Gilbert wrote: > > * Ilya Leoshkevich (i...@linux.ibm.com) wrote: > > > zlib_send_prepare() compresses pages of a running VM. zlib does not > > > make any thread-safety guarantees with respect to chan

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-07-05 Thread Ilya Leoshkevich
On Tue, 2022-07-05 at 16:27 +0100, Dr. David Alan Gilbert wrote: > * Ilya Leoshkevich (i...@linux.ibm.com) wrote: > > zlib_send_prepare() compresses pages of a running VM. zlib does not > > make any thread-safety guarantees with respect to changing > > deflate() > > input concurrently with deflate(

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-07-05 Thread Christian Borntraeger
Am 05.07.22 um 18:16 schrieb Dr. David Alan Gilbert: * Peter Maydell (peter.mayd...@linaro.org) wrote: On Mon, 4 Jul 2022 at 17:43, Ilya Leoshkevich wrote: zlib_send_prepare() compresses pages of a running VM. zlib does not make any thread-safety guarantees with respect to changing deflate()

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-07-05 Thread Dr. David Alan Gilbert
* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > Am 05.07.22 um 18:16 schrieb Dr. David Alan Gilbert: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On Mon, 4 Jul 2022 at 17:43, Ilya Leoshkevich wrote: > > > > > > > > zlib_send_prepare() compresses pages of a running VM. zli

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-07-05 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 4 Jul 2022 at 17:43, Ilya Leoshkevich wrote: > > > > zlib_send_prepare() compresses pages of a running VM. zlib does not > > make any thread-safety guarantees with respect to changing deflate() > > input concurrently with deflate() [1]. >

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-07-05 Thread Peter Maydell
On Mon, 4 Jul 2022 at 17:43, Ilya Leoshkevich wrote: > > zlib_send_prepare() compresses pages of a running VM. zlib does not > make any thread-safety guarantees with respect to changing deflate() > input concurrently with deflate() [1]. > > One can observe problems due to this with the IBM zEnterp

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-07-05 Thread Dr. David Alan Gilbert
* Ilya Leoshkevich (i...@linux.ibm.com) wrote: > zlib_send_prepare() compresses pages of a running VM. zlib does not > make any thread-safety guarantees with respect to changing deflate() > input concurrently with deflate() [1]. > > One can observe problems due to this with the IBM zEnterprise Dat

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-07-04 Thread Juan Quintela
Ilya Leoshkevich wrote: > zlib_send_prepare() compresses pages of a running VM. zlib does not > make any thread-safety guarantees with respect to changing deflate() > input concurrently with deflate() [1]. > > One can observe problems due to this with the IBM zEnterprise Data > Compression acceler

[PATCH] multifd: Copy pages before compressing them with zlib

2022-07-04 Thread Ilya Leoshkevich
zlib_send_prepare() compresses pages of a running VM. zlib does not make any thread-safety guarantees with respect to changing deflate() input concurrently with deflate() [1]. One can observe problems due to this with the IBM zEnterprise Data Compression accelerator capable zlib [2]. When the hard

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-04-04 Thread Dr. David Alan Gilbert
* Ilya Leoshkevich (i...@linux.ibm.com) wrote: > On Mon, 2022-04-04 at 12:20 +0100, Dr. David Alan Gilbert wrote: > > * Ilya Leoshkevich (i...@linux.ibm.com) wrote: > > > zlib_send_prepare() compresses pages of a running VM. zlib does not > > > make any thread-safety guarantees with respect to chan

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-04-04 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Apr 04, 2022 at 12:20:14PM +0100, Dr. David Alan Gilbert wrote: >> * Ilya Leoshkevich (i...@linux.ibm.com) wrote: >> > zlib_send_prepare() compresses pages of a running VM. zlib does not >> > make any thread-safety guarantees with respect to changing deflate() >

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-04-04 Thread Daniel P . Berrangé
On Mon, Apr 04, 2022 at 12:20:14PM +0100, Dr. David Alan Gilbert wrote: > * Ilya Leoshkevich (i...@linux.ibm.com) wrote: > > zlib_send_prepare() compresses pages of a running VM. zlib does not > > make any thread-safety guarantees with respect to changing deflate() > > input concurrently with defla

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-04-04 Thread Ilya Leoshkevich
On Mon, 2022-04-04 at 12:20 +0100, Dr. David Alan Gilbert wrote: > * Ilya Leoshkevich (i...@linux.ibm.com) wrote: > > zlib_send_prepare() compresses pages of a running VM. zlib does not > > make any thread-safety guarantees with respect to changing > > deflate() > > input concurrently with deflate(

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-04-04 Thread Dr. David Alan Gilbert
* Ilya Leoshkevich (i...@linux.ibm.com) wrote: > zlib_send_prepare() compresses pages of a running VM. zlib does not > make any thread-safety guarantees with respect to changing deflate() > input concurrently with deflate() [1]. > > One can observe problems due to this with the IBM zEnterprise Dat

Re: [PATCH] multifd: Copy pages before compressing them with zlib

2022-03-30 Thread Christian Borntraeger
Peter, Alex this is the fallout of Ilyas analysis of the s390x migration issue that triggered the DFLTCC workaround. Am 29.03.22 um 17:21 schrieb Ilya Leoshkevich: zlib_send_prepare() compresses pages of a running VM. zlib does not make any thread-safety guarantees with respect to changing defl

[PATCH] multifd: Copy pages before compressing them with zlib

2022-03-29 Thread Ilya Leoshkevich
zlib_send_prepare() compresses pages of a running VM. zlib does not make any thread-safety guarantees with respect to changing deflate() input concurrently with deflate() [1]. One can observe problems due to this with the IBM zEnterprise Data Compression accelerator capable zlib [2]. When the hard