Re: [PATCH] mos6522: remove anh register

2019-12-14 Thread Philippe Mathieu-Daudé
On 12/14/19 11:47 AM, Mark Cave-Ayland wrote: On 13/12/2019 08:45, Laurent Vivier wrote: Le 13/12/2019 à 02:44, David Gibson a écrit : On Thu, Dec 12, 2019 at 08:43:59PM +0100, Laurent Vivier wrote: Register addr 1 is defined as buffer A with handshake (vBufAH), register addr 15 is also define

Re: [PATCH] mos6522: remove anh register

2019-12-14 Thread Mark Cave-Ayland
On 13/12/2019 08:45, Laurent Vivier wrote: > Le 13/12/2019 à 02:44, David Gibson a écrit : >> On Thu, Dec 12, 2019 at 08:43:59PM +0100, Laurent Vivier wrote: >>> Register addr 1 is defined as buffer A with handshake (vBufAH), >>> register addr 15 is also defined as buffer A without handshake (vBuf

Re: [PATCH] mos6522: remove anh register

2019-12-13 Thread Philippe Mathieu-Daudé
On 12/12/19 8:43 PM, Laurent Vivier wrote: Register addr 1 is defined as buffer A with handshake (vBufAH), register addr 15 is also defined as buffer A without handshake (vBufA). Maybe add "IOW both addresses access the same register." Linux kernel has a big "DON'T USE!" next to the register

Re: [PATCH] mos6522: remove anh register

2019-12-13 Thread Laurent Vivier
Le 13/12/2019 à 02:44, David Gibson a écrit : > On Thu, Dec 12, 2019 at 08:43:59PM +0100, Laurent Vivier wrote: >> Register addr 1 is defined as buffer A with handshake (vBufAH), >> register addr 15 is also defined as buffer A without handshake (vBufA). >> >> Linux kernel has a big "DON'T USE!" nex

Re: [PATCH] mos6522: remove anh register

2019-12-12 Thread David Gibson
On Thu, Dec 12, 2019 at 08:43:59PM +0100, Laurent Vivier wrote: > Register addr 1 is defined as buffer A with handshake (vBufAH), > register addr 15 is also defined as buffer A without handshake (vBufA). > > Linux kernel has a big "DON'T USE!" next to the register 1 addr > definition (vBufAH), and

[PATCH] mos6522: remove anh register

2019-12-12 Thread Laurent Vivier
Register addr 1 is defined as buffer A with handshake (vBufAH), register addr 15 is also defined as buffer A without handshake (vBufA). Linux kernel has a big "DON'T USE!" next to the register 1 addr definition (vBufAH), and only uses register 15 (vBufA). So remove the definition of 'anh' and use