Re: [PATCH] monitor: flush messages on abort

2023-11-16 Thread Steven Sistare
On 11/16/2023 10:14 AM, Markus Armbruster wrote: > Steven Sistare writes: >> On 11/15/2023 11:15 AM, Markus Armbruster wrote: >>> Steven Sistare writes: On 11/15/2023 3:41 AM, Markus Armbruster wrote: > Daniel P. Berrangé writes: > >> On Fri, Nov 03, 2023 at 03:51:00PM -0400, St

Re: [PATCH] monitor: flush messages on abort

2023-11-16 Thread Markus Armbruster
Steven Sistare writes: > On 11/15/2023 11:15 AM, Markus Armbruster wrote: >> Steven Sistare writes: >>> On 11/15/2023 3:41 AM, Markus Armbruster wrote: Daniel P. Berrangé writes: > On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: >> On 11/3/2023 1:33 PM, Daniel

Re: [PATCH] monitor: flush messages on abort

2023-11-16 Thread Daniel P . Berrangé
On Wed, Nov 15, 2023 at 10:30:29AM -0500, Steven Sistare wrote: > > > On 11/6/2023 5:10 AM, Daniel P. Berrangé wrote: > > On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: > >> On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: > >>> On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sist

Re: [PATCH] monitor: flush messages on abort

2023-11-15 Thread Markus Armbruster
Steven Sistare writes: > On 11/15/2023 3:41 AM, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >>> On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: > On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote:

Re: [PATCH] monitor: flush messages on abort

2023-11-15 Thread Steven Sistare
On 11/15/2023 11:15 AM, Markus Armbruster wrote: > Steven Sistare writes: >> On 11/15/2023 3:41 AM, Markus Armbruster wrote: >>> Daniel P. Berrangé writes: >>> On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: > On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: >> On Fri,

Re: [PATCH] monitor: flush messages on abort

2023-11-15 Thread Markus Armbruster
Steven Sistare writes: > On 11/6/2023 5:10 AM, Daniel P. Berrangé wrote: >> On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: >>> On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote: > Buffered monitor output is lost

Re: [PATCH] monitor: flush messages on abort

2023-11-15 Thread Steven Sistare
On 11/15/2023 3:41 AM, Markus Armbruster wrote: > Daniel P. Berrangé writes: > >> On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: >>> On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote: > Buffered monitor output i

Re: [PATCH] monitor: flush messages on abort

2023-11-15 Thread Steven Sistare
On 11/6/2023 5:10 AM, Daniel P. Berrangé wrote: > On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: >> On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: >>> On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote: Buffered monitor output is lost when abort() is called. Th

Re: [PATCH] monitor: flush messages on abort

2023-11-15 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: >> On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: >> > On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote: >> >> Buffered monitor output is lost when abort() is called. The pattern >> >> erro

Re: [PATCH] monitor: flush messages on abort

2023-11-06 Thread Daniel P . Berrangé
On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote: > On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: > > On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote: > >> Buffered monitor output is lost when abort() is called. The pattern > >> error_report() followed by abort() occu

Re: [PATCH] monitor: flush messages on abort

2023-11-03 Thread Steven Sistare
On 11/3/2023 3:51 PM, Steven Sistare wrote: > On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: >> On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote: >>> Buffered monitor output is lost when abort() is called. The pattern >>> error_report() followed by abort() occurs about 60 times, so v

Re: [PATCH] monitor: flush messages on abort

2023-11-03 Thread Steven Sistare
On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote: > On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote: >> Buffered monitor output is lost when abort() is called. The pattern >> error_report() followed by abort() occurs about 60 times, so valuable >> information is being lost when the abo

Re: [PATCH] monitor: flush messages on abort

2023-11-03 Thread Daniel P . Berrangé
On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote: > Buffered monitor output is lost when abort() is called. The pattern > error_report() followed by abort() occurs about 60 times, so valuable > information is being lost when the abort is called in the context of a > monitor command.

[PATCH] monitor: flush messages on abort

2023-11-03 Thread Steve Sistare
Buffered monitor output is lost when abort() is called. The pattern error_report() followed by abort() occurs about 60 times, so valuable information is being lost when the abort is called in the context of a monitor command. To fix, install a SIGABRT handler to flush the monitor buffer to stderr