Re: [PATCH] monitor: Tidy up find_device_state()

2021-10-10 Thread Paolo Bonzini
On 16/09/21 13:17, Markus Armbruster wrote: Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept QOM paths in addition to qdev IDs. This added a checked conversion to TYPE_DEVICE at the end, which duplicates the check done for the qdev ID case

Re: [PATCH] monitor: Tidy up find_device_state()

2021-10-05 Thread Damien Hedde
On 9/16/21 13:17, Markus Armbruster wrote: Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept QOM paths in addition to qdev IDs. This added a checked conversion to TYPE_DEVICE at the end, which duplicates the check done for the qdev ID cas

Re: [PATCH] monitor: Tidy up find_device_state()

2021-10-01 Thread Markus Armbruster
Ping? Markus Armbruster writes: > Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" > extended find_device_state() to accept QOM paths in addition to qdev > IDs. This added a checked conversion to TYPE_DEVICE at the end, which > duplicates the check done for the qdev ID case ear

Re: [PATCH] monitor: Tidy up find_device_state()

2021-09-16 Thread Daniel P . Berrangé
On Thu, Sep 16, 2021 at 01:17:07PM +0200, Markus Armbruster wrote: > Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" > extended find_device_state() to accept QOM paths in addition to qdev > IDs. This added a checked conversion to TYPE_DEVICE at the end, which > duplicates the che

[PATCH] monitor: Tidy up find_device_state()

2021-09-16 Thread Markus Armbruster
Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept QOM paths in addition to qdev IDs. This added a checked conversion to TYPE_DEVICE at the end, which duplicates the check done for the qdev ID case earlier, except it sets a *different* error: G