Re: [PATCH] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-03-29 Thread Stefan Reiter
On 3/26/21 3:48 PM, Markus Armbruster wrote: Wolfgang Bumiller writes: On Thu, Mar 18, 2021 at 02:35:50PM +0100, Stefan Reiter wrote: If OOB is disabled, events received in monitor_qmp_event will be handled in the main context. Thus, we must not acquire a qmp_queue_lock there, as the dispatch

Re: [PATCH] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-03-26 Thread Markus Armbruster
Wolfgang Bumiller writes: > On Thu, Mar 18, 2021 at 02:35:50PM +0100, Stefan Reiter wrote: >> If OOB is disabled, events received in monitor_qmp_event will be handled >> in the main context. Thus, we must not acquire a qmp_queue_lock there, >> as the dispatcher coroutine holds one over a yield po

Re: [PATCH] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-03-22 Thread Stefan Reiter
On 3/22/21 12:08 PM, Wolfgang Bumiller wrote: On Thu, Mar 18, 2021 at 02:35:50PM +0100, Stefan Reiter wrote: If OOB is disabled, events received in monitor_qmp_event will be handled in the main context. Thus, we must not acquire a qmp_queue_lock there, as the dispatcher coroutine holds one over

Re: [PATCH] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-03-22 Thread Wolfgang Bumiller
On Thu, Mar 18, 2021 at 02:35:50PM +0100, Stefan Reiter wrote: > If OOB is disabled, events received in monitor_qmp_event will be handled > in the main context. Thus, we must not acquire a qmp_queue_lock there, > as the dispatcher coroutine holds one over a yield point, where it > expects to be res

[PATCH] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-03-18 Thread Stefan Reiter
If OOB is disabled, events received in monitor_qmp_event will be handled in the main context. Thus, we must not acquire a qmp_queue_lock there, as the dispatcher coroutine holds one over a yield point, where it expects to be rescheduled from the main context. If a CHR_EVENT_CLOSED event is received