Re: [PATCH] mingw: Fix builds on f33 mingw

2020-10-12 Thread Laurent Vivier
Le 12/10/2020 à 17:05, Peter Maydell a écrit : > On Mon, 12 Oct 2020 at 15:39, Laurent Vivier wrote: >> >> Le 08/10/2020 à 19:46, Thomas Huth a écrit : >>> On 08/10/2020 19.43, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Fedora 33's mingw moans about: >>

Re: [PATCH] mingw: Fix builds on f33 mingw

2020-10-12 Thread Peter Maydell
On Mon, 12 Oct 2020 at 15:39, Laurent Vivier wrote: > > Le 08/10/2020 à 19:46, Thomas Huth a écrit : > > On 08/10/2020 19.43, Dr. David Alan Gilbert (git) wrote: > >> From: "Dr. David Alan Gilbert" > >> > >> Fedora 33's mingw moans about: > >> > >> In file included from ../tests/test-bitmap.c:12:

Re: [PATCH] mingw: Fix builds on f33 mingw

2020-10-12 Thread Laurent Vivier
Le 08/10/2020 à 19:46, Thomas Huth a écrit : > On 08/10/2020 19.43, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> Fedora 33's mingw moans about: >> >> In file included from ../tests/test-bitmap.c:12: >> /home/dgilbert/git/migpull/include/qemu/osdep.h:76: error: >> "_

Re: [PATCH] mingw: Fix builds on f33 mingw

2020-10-08 Thread Philippe Mathieu-Daudé
On 10/8/20 7:43 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Fedora 33's mingw moans about: > > In file included from ../tests/test-bitmap.c:12: > /home/dgilbert/git/migpull/include/qemu/osdep.h:76: error: > "__USE_MINGW_ANSI_STDIO" redefined [-Werror] >76 |

Re: [PATCH] mingw: Fix builds on f33 mingw

2020-10-08 Thread Richard Henderson
On 10/8/20 12:43 PM, Dr. David Alan Gilbert (git) wrote: > -#include > #include "qemu/osdep.h" > +#include As pointed out by pmm earlier, for someone else's version of this patch, should simply be removed here -- it's already included by osdep.h. r~

Re: [PATCH] mingw: Fix builds on f33 mingw

2020-10-08 Thread Thomas Huth
On 08/10/2020 19.43, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Fedora 33's mingw moans about: > > In file included from ../tests/test-bitmap.c:12: > /home/dgilbert/git/migpull/include/qemu/osdep.h:76: error: > "__USE_MINGW_ANSI_STDIO" redefined [-Werror] >76 |

[PATCH] mingw: Fix builds on f33 mingw

2020-10-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Fedora 33's mingw moans about: In file included from ../tests/test-bitmap.c:12: /home/dgilbert/git/migpull/include/qemu/osdep.h:76: error: "__USE_MINGW_ANSI_STDIO" redefined [-Werror] 76 | #define __USE_MINGW_ANSI_STDIO 1 | the fix is to make sure osdep.