Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-08-05 Thread Markus Armbruster
Peter Xu writes: > On Fri, Aug 04, 2023 at 02:06:02PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Wed, Jul 26, 2023 at 08:21:35AM +0200, Markus Armbruster wrote: >> >> Peter Xu writes: >> >> >> >> > Hi, Markus, >> >> > >> >> > On Tue, Jul 25, 2023 at 01:10:01PM +0200, Marku

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-08-05 Thread Markus Armbruster
Peter Xu writes: > On Fri, Aug 04, 2023 at 02:39:15PM +0100, Daniel P. Berrangé wrote: >> On Wed, Jul 26, 2023 at 11:12:31AM -0400, Peter Xu wrote: >> > On Wed, Jul 26, 2023 at 08:21:35AM +0200, Markus Armbruster wrote: >> > > Peter Xu writes: >> > > >> > > > Hi, Markus, >> > > > >> > > > On Tu

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-08-04 Thread Peter Xu
On Fri, Aug 04, 2023 at 02:39:15PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 26, 2023 at 11:12:31AM -0400, Peter Xu wrote: > > On Wed, Jul 26, 2023 at 08:21:35AM +0200, Markus Armbruster wrote: > > > Peter Xu writes: > > > > > > > Hi, Markus, > > > > > > > > On Tue, Jul 25, 2023 at 01:10:01P

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-08-04 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 11:12:31AM -0400, Peter Xu wrote: > On Wed, Jul 26, 2023 at 08:21:35AM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > Hi, Markus, > > > > > > On Tue, Jul 25, 2023 at 01:10:01PM +0200, Markus Armbruster wrote: > > > > [...] > > > > >> For better or worse,

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-08-04 Thread Peter Xu
On Fri, Aug 04, 2023 at 02:06:02PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Jul 26, 2023 at 08:21:35AM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > Hi, Markus, > >> > > >> > On Tue, Jul 25, 2023 at 01:10:01PM +0200, Markus Armbruster wrote: > >> > >

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-08-04 Thread Markus Armbruster
Peter Xu writes: > On Wed, Jul 26, 2023 at 08:21:35AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Hi, Markus, >> > >> > On Tue, Jul 25, 2023 at 01:10:01PM +0200, Markus Armbruster wrote: >> >> [...] >> >> >> For better or worse, we duplicate full documentation between >> >> Mi

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-26 Thread Peter Xu
On Tue, Jul 25, 2023 at 06:10:18PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 25, 2023 at 12:38:23PM -0400, Peter Xu wrote: > > I see you used "convergance" explicitly even after PeterM's reply, is that > > what you prefer over "convergence"? I do see more occurances of > > "convergence" as a

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-26 Thread Peter Xu
On Wed, Jul 26, 2023 at 08:21:35AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Hi, Markus, > > > > On Tue, Jul 25, 2023 at 01:10:01PM +0200, Markus Armbruster wrote: > > [...] > > >> For better or worse, we duplicate full documentation between > >> MigrationParameter, MigrateSetPar

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-25 Thread Markus Armbruster
Peter Xu writes: > Hi, Markus, > > On Tue, Jul 25, 2023 at 01:10:01PM +0200, Markus Armbruster wrote: [...] >> For better or worse, we duplicate full documentation between >> MigrationParameter, MigrateSetParameters, and MigrationParameters. This >> would be the first instance where we referen

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-25 Thread Daniel P . Berrangé
On Tue, Jul 25, 2023 at 12:38:23PM -0400, Peter Xu wrote: > I see you used "convergance" explicitly even after PeterM's reply, is that > what you prefer over "convergence"? I do see more occurances of > "convergence" as a word in migration context, though. Ignore my speling erors :-) >

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-25 Thread Peter Xu
Hi, Markus, On Tue, Jul 25, 2023 at 01:10:01PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Migration bandwidth is a very important value to live migration. It's > > because it's one of the major factors that we'll make decision on when to > > switchover to destination in a precopy

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-25 Thread Peter Xu
On Tue, Jul 25, 2023 at 05:09:57PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 25, 2023 at 11:54:52AM -0400, Peter Xu wrote: > > We can make the semantics specific, no strong opinion here. I wished it > > can be as generic / easy as possible but maybe I went too far. > > > > Though, is there a

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-25 Thread Daniel P . Berrangé
On Tue, Jul 25, 2023 at 11:54:52AM -0400, Peter Xu wrote: > We can make the semantics specific, no strong opinion here. I wished it > can be as generic / easy as possible but maybe I went too far. > > Though, is there anything else we can choose from besides > "max-convergence-bandwidth"? Or am I

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-25 Thread Peter Xu
On Tue, Jul 25, 2023 at 10:16:52AM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 24, 2023 at 03:47:50PM -0400, Peter Xu wrote: > > On Mon, Jul 24, 2023 at 07:04:29PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jul 24, 2023 at 01:07:55PM -0400, Peter Xu wrote: > > > > Migration bandwidth is a ve

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-25 Thread Markus Armbruster
Peter Xu writes: > Migration bandwidth is a very important value to live migration. It's > because it's one of the major factors that we'll make decision on when to > switchover to destination in a precopy process. > > This value is currently estimated by QEMU during the whole live migration > p

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-25 Thread Daniel P . Berrangé
On Mon, Jul 24, 2023 at 03:47:50PM -0400, Peter Xu wrote: > On Mon, Jul 24, 2023 at 07:04:29PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 24, 2023 at 01:07:55PM -0400, Peter Xu wrote: > > > Migration bandwidth is a very important value to live migration. It's > > > because it's one of the ma

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-24 Thread Peter Xu
On Mon, Jul 24, 2023 at 07:04:29PM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 24, 2023 at 01:07:55PM -0400, Peter Xu wrote: > > Migration bandwidth is a very important value to live migration. It's > > because it's one of the major factors that we'll make decision on when to > > switchover to

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-24 Thread Peter Maydell
On Mon, 24 Jul 2023 at 19:05, Daniel P. Berrangé wrote: > > I feel like rather than "available-bandwidth", we should call > it "max-convergance-bandwidth". "convergence" (I mention only since it's a proposed user-visible bit of API :-) -- PMM

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-24 Thread Daniel P . Berrangé
On Mon, Jul 24, 2023 at 01:07:55PM -0400, Peter Xu wrote: > Migration bandwidth is a very important value to live migration. It's > because it's one of the major factors that we'll make decision on when to > switchover to destination in a precopy process. To elaborate on this for those reading al

[PATCH] migration: Allow user to specify migration available bandwidth

2023-07-24 Thread Peter Xu
Migration bandwidth is a very important value to live migration. It's because it's one of the major factors that we'll make decision on when to switchover to destination in a precopy process. This value is currently estimated by QEMU during the whole live migration process by monitoring how fast