Re: [PATCH] migration/multifd: Document two places for mapped-ram

2024-03-03 Thread Prasad Pandit
On Mon, 4 Mar 2024 at 06:00, Peter Xu wrote: > Yes I think you're looking at the right path, it's just that the relevant > patches haven't yet landed upstream but is planned. I normally use > "Based-on" tag for such patch that has a dependency outside master, like: > > Based-on: <20240229153017.2

Re: [PATCH] migration/multifd: Document two places for mapped-ram

2024-03-03 Thread Peter Xu
On Fri, Mar 01, 2024 at 05:50:24PM +, Daniel P. Berrangé wrote: > On Fri, Mar 01, 2024 at 11:17:10PM +0530, Prasad Pandit wrote: > > Hello Petr, Hey Prasad! Thanks for taking a look. > > > > On Fri, 1 Mar 2024 at 14:46, wrote: > > > + * An explicitly close() on the channel here is

Re: [PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread Daniel P . Berrangé
On Fri, Mar 01, 2024 at 11:17:10PM +0530, Prasad Pandit wrote: > Hello Petr, > > On Fri, 1 Mar 2024 at 14:46, wrote: > > + * An explicitly close() on the channel here is normally not > > explicitly -> explicit > > > + * required, but can be helpful for "file:" iochannels, where

Re: [PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread Prasad Pandit
Hello Petr, On Fri, 1 Mar 2024 at 14:46, wrote: > + * An explicitly close() on the channel here is normally not explicitly -> explicit > + * required, but can be helpful for "file:" iochannels, where it > + * will include an fdatasync() to make sure the data is flushed t

Re: [PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread Fabiano Rosas
pet...@redhat.com writes: > From: Peter Xu > > Add two documentations for mapped-ram migration on two spots that may not > be extremely clear. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas

[PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread peterx
From: Peter Xu Add two documentations for mapped-ram migration on two spots that may not be extremely clear. Signed-off-by: Peter Xu --- Based-on: <20240229153017.2221-1-faro...@suse.de> --- migration/multifd.c | 12 migration/ram.c | 8 +++- 2 files changed, 19 insertion