Re: [PATCH] migration/dirtyrate: Silence warning about strcpy() on OpenBSD

2024-10-17 Thread Peter Maydell
On Thu, 17 Oct 2024 at 06:41, Thomas Huth wrote: > > On 16/10/2024 18.22, Daniel P. Berrangé wrote: > > On Wed, Oct 16, 2024 at 06:07:12PM +0200, Thomas Huth wrote: > >> The linker on OpenBSD complains: > >> > >> ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...): > >> warnin

Re: [PATCH] migration/dirtyrate: Silence warning about strcpy() on OpenBSD

2024-10-17 Thread Yong Huang
On Thu, Oct 17, 2024 at 1:40 PM Thomas Huth wrote: > On 16/10/2024 18.22, Daniel P. Berrangé wrote: > > On Wed, Oct 16, 2024 at 06:07:12PM +0200, Thomas Huth wrote: > >> The linker on OpenBSD complains: > >> > >> ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...): > >> warni

Re: [PATCH] migration/dirtyrate: Silence warning about strcpy() on OpenBSD

2024-10-16 Thread Thomas Huth
On 16/10/2024 18.22, Daniel P. Berrangé wrote: On Wed, Oct 16, 2024 at 06:07:12PM +0200, Thomas Huth wrote: The linker on OpenBSD complains: ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...): warning: strcpy() is almost always misused, please use strlcpy() Is that the o

Re: [PATCH] migration/dirtyrate: Silence warning about strcpy() on OpenBSD

2024-10-16 Thread Peter Xu
On Wed, Oct 16, 2024 at 05:22:11PM +0100, Daniel P. Berrangé wrote: > On Wed, Oct 16, 2024 at 06:07:12PM +0200, Thomas Huth wrote: > > The linker on OpenBSD complains: > > > > ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...): > > warning: strcpy() is almost always misused, pl

Re: [PATCH] migration/dirtyrate: Silence warning about strcpy() on OpenBSD

2024-10-16 Thread Daniel P . Berrangé
On Wed, Oct 16, 2024 at 06:07:12PM +0200, Thomas Huth wrote: > The linker on OpenBSD complains: > > ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...): > warning: strcpy() is almost always misused, please use strlcpy() Is that the only place it complains ? We use 'strcpy' in

[PATCH] migration/dirtyrate: Silence warning about strcpy() on OpenBSD

2024-10-16 Thread Thomas Huth
The linker on OpenBSD complains: ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...): warning: strcpy() is almost always misused, please use strlcpy() It's currently not a real problem in this case since both arrays have the same size (256 bytes). But just in case somebody chan