Re: [PATCH] meson: set colorout to auto

2020-08-30 Thread Paolo Bonzini
On 25/08/20 10:11, Marc-André Lureau wrote: > > As far I know make doesn't redirect output.  Or maybe it redirects using > a pty (instead of a pipe) in case stdout is a terminal.  At least auto > mode for colored gcc warnings works fine with make.  It is colored when > started in a

Re: [PATCH] meson: set colorout to auto

2020-08-25 Thread Gerd Hoffmann
On Tue, Aug 25, 2020 at 06:26:33AM -0700, Richard Henderson wrote: > On 8/24/20 11:43 PM, Gerd Hoffmann wrote: > > Dunno why the default is set to "always". IMHO it should be "auto", > > i.e. only colorize in case stdout goes to a terminal. Cluttering > > logfiles and confusing compiler message p

Re: [PATCH] meson: set colorout to auto

2020-08-25 Thread Richard Henderson
On 8/24/20 11:43 PM, Gerd Hoffmann wrote: > Dunno why the default is set to "always". IMHO it should be "auto", > i.e. only colorize in case stdout goes to a terminal. Cluttering > logfiles and confusing compiler message parsers with terminal control > sequences is not nice ... > > Signed-off-by

Re: [PATCH] meson: set colorout to auto

2020-08-25 Thread Marc-André Lureau
Hi On Tue, Aug 25, 2020 at 12:07 PM Gerd Hoffmann wrote: > On Tue, Aug 25, 2020 at 10:59:42AM +0400, Marc-André Lureau wrote: > > Hi > > > > On Tue, Aug 25, 2020 at 10:44 AM Gerd Hoffmann > wrote: > > > > > Dunno why the default is set to "always". IMHO it should be "auto", > > > i.e. only col

Re: [PATCH] meson: set colorout to auto

2020-08-25 Thread Gerd Hoffmann
On Tue, Aug 25, 2020 at 10:59:42AM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Aug 25, 2020 at 10:44 AM Gerd Hoffmann wrote: > > > Dunno why the default is set to "always". IMHO it should be "auto", > > i.e. only colorize in case stdout goes to a terminal. Cluttering > > logfiles and con

Re: [PATCH] meson: set colorout to auto

2020-08-25 Thread Marc-André Lureau
Hi On Tue, Aug 25, 2020 at 10:44 AM Gerd Hoffmann wrote: > Dunno why the default is set to "always". IMHO it should be "auto", > i.e. only colorize in case stdout goes to a terminal. Cluttering > logfiles and confusing compiler message parsers with terminal control > sequences is not nice ...

[PATCH] meson: set colorout to auto

2020-08-24 Thread Gerd Hoffmann
Dunno why the default is set to "always". IMHO it should be "auto", i.e. only colorize in case stdout goes to a terminal. Cluttering logfiles and confusing compiler message parsers with terminal control sequences is not nice ... Signed-off-by: Gerd Hoffmann --- meson.build | 3 ++- 1 file chan