Re: [PATCH] meson: remove -no-pie linker flag

2023-05-23 Thread Richard Henderson
On 5/23/23 01:18, Daniel P. Berrangé wrote: On Tue, May 23, 2023 at 10:02:51AM +0200, Paolo Bonzini wrote: On Tue, May 23, 2023 at 10:00 AM Daniel P. Berrangé wrote: I'm curious why we need to do anything ? I would have thought that meson should handle 'b_pie' itself, passing the right args t

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-23 Thread Paolo Bonzini
On Tue, May 23, 2023 at 10:18 AM Daniel P. Berrangé wrote: > > The issue is that Meson only has "enable PIE" or "leave PIE to the > > compiler default", while QEMU also has "disable PIE"---which is the > > messy one. > > Does QEMU actually need "disable PIE" ? It existed in configure of > course,

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-23 Thread Daniel P . Berrangé
On Tue, May 23, 2023 at 10:02:51AM +0200, Paolo Bonzini wrote: > On Tue, May 23, 2023 at 10:00 AM Daniel P. Berrangé > wrote: > > I'm curious why we need to do anything ? I would have thought that meson > > should handle 'b_pie' itself, passing the right args to $CC that it feels > > are appropr

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-23 Thread Paolo Bonzini
On Tue, May 23, 2023 at 10:00 AM Daniel P. Berrangé wrote: > I'm curious why we need to do anything ? I would have thought that meson > should handle 'b_pie' itself, passing the right args to $CC that it feels > are appropriate. I don't recall seeing other apps using meson trying to > handle b_pi

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-23 Thread Daniel P . Berrangé
On Mon, May 22, 2023 at 10:08:16AM +0200, Paolo Bonzini wrote: > The large comment in the patch says it all; the -no-pie flag is broken and > this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614 > ("build: move remaining compiler flag tests to meson", 2023-05-18). > > Resolves

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-23 Thread Michael Tokarev
22.05.2023 18:54, Richard Henderson wrote: .. -no-pie is a linker flag, but distro folk that didn't quite know what they were doing made local changes to gcc's specs file.  So it *is* a compiler command-line flag, but only for some builds of gcc. Which distros is that? Debian? Patching gcc spec

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-23 Thread Paolo Bonzini
On Mon, May 22, 2023 at 4:39 PM Richard Henderson wrote: > > + # What about linker flags? For a static build, no PIE is implied by > > -static > > + # which we added above. > > Is it though? That was the major problem at the time: it wasn't. It's what configure was doing: if test "$static"

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-22 Thread Volker Rümelin
Am 22.05.23 um 10:08 schrieb Paolo Bonzini: The large comment in the patch says it all; the -no-pie flag is broken and this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614 ("build: move remaining compiler flag tests to meson", 2023-05-18). Resolves: https://gitlab.com/qemu-p

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-22 Thread Richard Henderson
On 5/22/23 01:08, Paolo Bonzini wrote: The large comment in the patch says it all; the -no-pie flag is broken and this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614 ("build: move remaining compiler flag tests to meson", 2023-05-18). It's not nearly as simple as that. +

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-22 Thread Richard Henderson
On 5/22/23 01:08, Paolo Bonzini wrote: The large comment in the patch says it all; the -no-pie flag is broken and this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614 ("build: move remaining compiler flag tests to meson", 2023-05-18). Resolves: https://gitlab.com/qemu-projec

Re: [PATCH] meson: remove -no-pie linker flag

2023-05-22 Thread Philippe Mathieu-Daudé
On 22/5/23 10:08, Paolo Bonzini wrote: The large comment in the patch says it all; the -no-pie flag is broken and this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614 ("build: move remaining compiler flag tests to meson", 2023-05-18). Resolves: https://gitlab.com/qemu-projec

[PATCH] meson: remove -no-pie linker flag

2023-05-22 Thread Paolo Bonzini
The large comment in the patch says it all; the -no-pie flag is broken and this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614 ("build: move remaining compiler flag tests to meson", 2023-05-18). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1664 Signed-off-by: Paolo