Re: [PATCH] m48t59-test: remove shadowed variables and cleanup

2023-09-26 Thread Markus Armbruster
Thomas Huth writes: > On 25/09/2023 16.47, Paolo Bonzini wrote: >> Rename the variable "s" and, while at it, avoid the chance of an overflow in >> the >> computation of ABS(t - s). >> Signed-off-by: Paolo Bonzini >> --- >> tests/qtest/m48t59-test.c | 17 ++--- >> 1 file changed,

Re: [PATCH] m48t59-test: remove shadowed variables and cleanup

2023-09-25 Thread Thomas Huth
On 25/09/2023 16.47, Paolo Bonzini wrote: Rename the variable "s" and, while at it, avoid the chance of an overflow in the computation of ABS(t - s). Signed-off-by: Paolo Bonzini --- tests/qtest/m48t59-test.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) I've got

[PATCH] m48t59-test: remove shadowed variables and cleanup

2023-09-25 Thread Paolo Bonzini
Rename the variable "s" and, while at it, avoid the chance of an overflow in the computation of ABS(t - s). Signed-off-by: Paolo Bonzini --- tests/qtest/m48t59-test.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tests/qtest/m48t59-test.c b/tests/qtest/m4