Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Daniel Brodsky
On Thu, Mar 19, 2020 at 1:53 PM Eric Blake wrote: > > Hmm. This one is a different failure than the other patchew warnings > about variable redefinition; but is still evidence that it is missing > your "[PATCH] misc: fix __COUNTER__ macro to be referenced properly". > At any rate, the fact that w

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Daniel Brodsky
On Thu, Mar 19, 2020 at 1:48 PM Eric Blake wrote: > > On 3/19/20 11:19 AM, dnbrd...@gmail.com wrote: > > From: danbrodsky > > > > - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets > > - replaced result with QEMU_LOCK_GUARD if all unlocks at function end > > - replaced result with WITH_

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Eric Blake
On 3/19/20 2:31 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Eric Blake
On 3/19/20 2:39 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can proba

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Eric Blake
On 3/19/20 11:19 AM, dnbrd...@gmail.com wrote: From: danbrodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: danbrodsky --- b

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ex

[PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread dnbrdsky
From: danbrodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: danbrodsky --- block/iscsi.c | 23 +++ blo