Re: [PATCH] linux-user: fix resource leaks in gen-vdso

2025-04-04 Thread Richard Henderson
On 2/19/25 02:03, Daniel P. Berrangé wrote: + cleanup: +free(buf); + +if (outf && +fclose(outf) != 0) +ret = EXIT_FAILURE; +if (inf && +fclose(inf) != 0) +ret = EXIT_FAILURE; +return ret; Modulo the lack of braces here, the patch looks fine. r~

Re: [PATCH] linux-user: fix resource leaks in gen-vdso

2025-03-20 Thread Daniel P . Berrangé
ping, any thoughts on this patch On Wed, Feb 19, 2025 at 10:03:36AM +, Daniel P. Berrangé wrote: > There are a number of resource leaks in gen-vdso. In theory they are > harmless because this is a short lived process, but when building QEMU > with --extra-cflags="-fsanitize=address" problems e

[PATCH] linux-user: fix resource leaks in gen-vdso

2025-02-19 Thread Daniel P . Berrangé
There are a number of resource leaks in gen-vdso. In theory they are harmless because this is a short lived process, but when building QEMU with --extra-cflags="-fsanitize=address" problems ensure. The gen-vdso program is run as part of the build, and that aborts due to the sanitizer identifying me