Re: [PATCH] linux-user: Remove pointless NULL check in clock_adjtime handling

2023-07-13 Thread Peter Maydell
I'll take this via target-arm.next unless there are any objections... thanks -- PMM On Tue, 4 Jul 2023 at 14:26, Peter Maydell wrote: > > Laurent, ping? This patch has been reviewed. > > thanks > -- PMM > > On Fri, 23 Jun 2023 at 15:44, Peter Maydell wrote: > > > > In the code for TARGET_NR_clo

Re: [PATCH] linux-user: Remove pointless NULL check in clock_adjtime handling

2023-07-04 Thread Peter Maydell
Laurent, ping? This patch has been reviewed. thanks -- PMM On Fri, 23 Jun 2023 at 15:44, Peter Maydell wrote: > > In the code for TARGET_NR_clock_adjtime, we set the pointer phtx to > the address of the local variable htx. This means it can never be > NULL, but later in the code we check it for

Re: [PATCH] linux-user: Remove pointless NULL check in clock_adjtime handling

2023-06-26 Thread Richard Henderson
On 6/23/23 16:44, Peter Maydell wrote: In the code for TARGET_NR_clock_adjtime, we set the pointer phtx to the address of the local variable htx. This means it can never be NULL, but later in the code we check it for NULL anyway. Coverity complains about this (CID 1507683) because the NULL chec

Re: [PATCH] linux-user: Remove pointless NULL check in clock_adjtime handling

2023-06-23 Thread Philippe Mathieu-Daudé
On 23/6/23 16:44, Peter Maydell wrote: In the code for TARGET_NR_clock_adjtime, we set the pointer phtx to the address of the local variable htx. This means it can never be NULL, but later in the code we check it for NULL anyway. Coverity complains about this (CID 1507683) because the NULL chec

[PATCH] linux-user: Remove pointless NULL check in clock_adjtime handling

2023-06-23 Thread Peter Maydell
In the code for TARGET_NR_clock_adjtime, we set the pointer phtx to the address of the local variable htx. This means it can never be NULL, but later in the code we check it for NULL anyway. Coverity complains about this (CID 1507683) because the NULL check comes after a call to clock_adjtime() t