Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-09-27 Thread Laurent Vivier
Le 25/07/2022 à 13:00, Peter Maydell a écrit : For handling guest POSIX timers, we currently use an array g_posix_timers[], whose entries are a host timer_t value, or 0 for "this slot is unused". When the guest calls the timer_create syscall we look through the array for a slot containing 0, and

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-08-10 Thread Peter Maydell
On Wed, 10 Aug 2022 at 06:59, Laurent Vivier wrote: > > Le 09/08/2022 à 11:51, Peter Maydell a écrit : > > Laurent, ping ? > > Sorry, I didn't see your message. I'm going to apply it if it's ok to go into > rc3? Not sure about rc3; I'd have been OK with it in rc2 but I think it could probably us

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-08-09 Thread Laurent Vivier
Le 09/08/2022 à 11:51, Peter Maydell a écrit : Laurent, ping ? Sorry, I didn't see your message. I'm going to apply it if it's ok to go into rc3? Thanks, Laurent thanks -- PMM On Mon, 1 Aug 2022 at 12:43, Peter Maydell wrote: On Mon, 25 Jul 2022 at 12:13, Daniel P. Berrangé wrote: O

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-08-09 Thread Peter Maydell
Laurent, ping ? thanks -- PMM On Mon, 1 Aug 2022 at 12:43, Peter Maydell wrote: > > On Mon, 25 Jul 2022 at 12:13, Daniel P. Berrangé wrote: > > > > On Mon, Jul 25, 2022 at 12:00:35PM +0100, Peter Maydell wrote: > > > For handling guest POSIX timers, we currently use an array > > > g_posix_timer

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-08-01 Thread Peter Maydell
On Mon, 25 Jul 2022 at 12:13, Daniel P. Berrangé wrote: > > On Mon, Jul 25, 2022 at 12:00:35PM +0100, Peter Maydell wrote: > > For handling guest POSIX timers, we currently use an array > > g_posix_timers[], whose entries are a host timer_t value, or 0 for > > "this slot is unused". When the gues

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-07-29 Thread Peter Maydell
On Tue, 26 Jul 2022 at 23:13, Jon Alduan wrote: > > Hello Peter, > > I can say so far, your patch solved the issue! Great thanks for that! > > Regarding the libc version: > From my WSL2 Ubuntu 21.04 x86_64: > $ ls -l /lib32/libc* > -rwxr-xr-x 1 root root 2042632 Mar 31 2021 /lib32/libc-2.33.so >

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-07-26 Thread Jon Alduan
Hello Peter, I can say so far, your patch solved the issue! Great thanks for that! Regarding the libc version: >From my WSL2 Ubuntu 21.04 x86_64: $ ls -l /lib32/libc* -rwxr-xr-x 1 root root 2042632 Mar 31 2021 /lib32/libc-2.33.so My gcc version 10 does use the same libc version. As already ment

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-07-25 Thread Peter Maydell
On Mon, 25 Jul 2022 at 12:13, Daniel P. Berrangé wrote: > > On Mon, Jul 25, 2022 at 12:00:35PM +0100, Peter Maydell wrote: > > For handling guest POSIX timers, we currently use an array > > g_posix_timers[], whose entries are a host timer_t value, or 0 for > > "this slot is unused". When the gues

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-07-25 Thread Daniel P . Berrangé
On Mon, Jul 25, 2022 at 12:00:35PM +0100, Peter Maydell wrote: > For handling guest POSIX timers, we currently use an array > g_posix_timers[], whose entries are a host timer_t value, or 0 for > "this slot is unused". When the guest calls the timer_create syscall > we look through the array for a

[PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-07-25 Thread Peter Maydell
For handling guest POSIX timers, we currently use an array g_posix_timers[], whose entries are a host timer_t value, or 0 for "this slot is unused". When the guest calls the timer_create syscall we look through the array for a slot containing 0, and use that for the new timer. This scheme assumes