Re: [PATCH] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-08 Thread Stefan Hajnoczi
On Thu, Apr 08, 2021 at 12:37:36PM +0200, Laurent Vivier wrote: > On 07/04/2021 12:45, Stefan Hajnoczi wrote: > > Some downstreams rename the QEMU binary to "qemu-kvm". This breaks > > qtest_get_arch(), which attempts to parse the target architecture from > > the QTEST_QEMU_BINARY environment varia

Re: [PATCH] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-08 Thread Peter Maydell
On Wed, 7 Apr 2021 at 11:46, Stefan Hajnoczi wrote: > > Some downstreams rename the QEMU binary to "qemu-kvm". This breaks > qtest_get_arch(), which attempts to parse the target architecture from > the QTEST_QEMU_BINARY environment variable. > > Print an error instead of returning the architecture

Re: [PATCH] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-08 Thread Laurent Vivier
On 07/04/2021 12:45, Stefan Hajnoczi wrote: > Some downstreams rename the QEMU binary to "qemu-kvm". This breaks > qtest_get_arch(), which attempts to parse the target architecture from > the QTEST_QEMU_BINARY environment variable. > > Print an error instead of returning the architecture "kvm". Th

[PATCH] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-07 Thread Stefan Hajnoczi
Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTEST_QEMU_BINARY environment variable. Print an error instead of returning the architecture "kvm". Things fail in weird ways when the architecture string i