Re: Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-28 Thread Peter Maydell
On Mon, 28 Mar 2022 at 13:17, wrote: > > thanks for you explain, I will learn it later. > > > in the scenario of rom bar size 8k, page size 64k, the value of > > 'size = ROUND_UP(size, qemu_real_host_page_size)' is 64k, kvm_align_section > > also return 64k bytes. just the same size as the size o

回复: Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-28 Thread liucong2
  } -       qdev->ram_header = ioremap(qdev->vram_base ++       qdev->ram_header = ioremap_wc(qdev->vram_base +                                   qdev->rom->ram_header_offset,                                   sizeof(*qdev->ram_header));        if (!qdev->ram_header) {Regards,Cong.        主 题:Re: [PATC

Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-28 Thread Peter Maydell
On Mon, 28 Mar 2022 at 10:42, Cong Liu wrote: > On 2022/3/25 23:00, Peter Maydell wrote: > > This is correct behaviour. If the memory region is less than > > a complete host page then it is not possible for KVM to > > map it into the guest as directly accessible memory, > > because that can only b

Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-28 Thread Cong Liu
On 2022/3/25 23:00, Peter Maydell wrote: On Fri, 25 Mar 2022 at 14:42, wrote: I found this issue on qmeu 4.2 with host linux 4.19, I want to use qxl on arm64. on arm64, default page size is 64k, and the qxl_rom_size is fixed 8192. OK, so the fix to this is "use a newer QEMU". but when I

Re: Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-25 Thread Peter Maydell
On Fri, 25 Mar 2022 at 14:42, wrote: > I found this issue on qmeu 4.2 with host linux 4.19, I want to > use qxl on arm64. on arm64, default page size is 64k, and the > qxl_rom_size is fixed 8192. OK, so the fix to this is "use a newer QEMU". > but when I read qxl_rom region in guest, guest os st

Re: Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-25 Thread liucong2
ppear. but when others create a memory region with the size less than onepage. when it run into kvm_align_section, it return 0again.RegardsCong.        主 题:Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm            日 期:2022-03-25 21:12            发件人:Peter Maydell        

Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-25 Thread Peter Maydell
On Fri, 18 Mar 2022 at 14:24, Cong Liu wrote: > > on the arm64 platform, the PAGESIZE is 64k, the default qxl rom > bar size is 8k(QXL_ROM_SZ), in the case memory size less than > one page size, kvm_align_section return zero, the memory section > did not commit kvm. Can you give more details on

[PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-18 Thread Cong Liu
on the arm64 platform, the PAGESIZE is 64k, the default qxl rom bar size is 8k(QXL_ROM_SZ), in the case memory size less than one page size, kvm_align_section return zero, the memory section did not commit kvm. Signed-off-by: Cong Liu --- accel/kvm/kvm-all.c | 1 + 1 file changed, 1 insertion(+