Re: [PATCH] job: delete job_{lock, unlock} functions and replace them with lock guard

2020-09-30 Thread Paolo Bonzini
On 30/09/20 14:15, Elena Afanasova wrote: >>> +WITH_QEMU_LOCK_GUARD(&job_mutex) { >>> +if (ns != -1) { >>> +timer_mod(&job->sleep_timer, ns); >>> +} >>> +job->busy = false; >>> +job_event_idle(job); >> Is this new macro safe to use in a coroutine cont

Re: [PATCH] job: delete job_{lock,unlock} functions and replace them with lock guard

2020-09-30 Thread Elena Afanasova
On Tue, 2020-09-29 at 14:04 -0400, John Snow wrote: > On 9/29/20 9:42 AM, Elena Afanasova wrote: > > Signed-off-by: Elena Afanasova > > Hi, can I have a commit message here, please? > > > --- > > job.c | 46 +- > > 1 file changed, 17 insertions(+),

Re: [PATCH] job: delete job_{lock, unlock} functions and replace them with lock guard

2020-09-29 Thread John Snow
On 9/29/20 9:42 AM, Elena Afanasova wrote: Signed-off-by: Elena Afanasova Hi, can I have a commit message here, please? --- job.c | 46 +- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/job.c b/job.c index 8fecf38960..89ceb53434

[PATCH] job: delete job_{lock, unlock} functions and replace them with lock guard

2020-09-29 Thread Elena Afanasova
Signed-off-by: Elena Afanasova --- job.c | 46 +- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/job.c b/job.c index 8fecf38960..89ceb53434 100644 --- a/job.c +++ b/job.c @@ -79,16 +79,6 @@ struct JobTxn { * job_enter. */ static Qemu