Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
02.02.2021 17:28, Kevin Wolf wrote: If the qemu-system-{arch} binary for the host architecture can't be found, the old 'check' implementation selected the alphabetically first system emulator binary that it could find. The new Python implementation just uses the first result of glob.iglob(), whic

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Philippe Mathieu-Daudé
On 2/2/21 3:56 PM, Daniel P. Berrangé wrote: > On Tue, Feb 02, 2021 at 03:46:11PM +0100, Philippe Mathieu-Daudé wrote: >> On 2/2/21 3:28 PM, Kevin Wolf wrote: >>> If the qemu-system-{arch} binary for the host architecture can't be >>> found, the old 'check' implementation selected the alphabeticall

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Eric Blake
On 2/2/21 8:28 AM, Kevin Wolf wrote: > If the qemu-system-{arch} binary for the host architecture can't be > found, the old 'check' implementation selected the alphabetically first > system emulator binary that it could find. The new Python implementation > just uses the first result of glob.iglob(

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 03:46:11PM +0100, Philippe Mathieu-Daudé wrote: > On 2/2/21 3:28 PM, Kevin Wolf wrote: > > If the qemu-system-{arch} binary for the host architecture can't be > > found, the old 'check' implementation selected the alphabetically first > > system emulator binary that it could

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Philippe Mathieu-Daudé
Forgot to Cc Wainer & Willian in case they are interested in providing a better long term fix. On 2/2/21 3:46 PM, Philippe Mathieu-Daudé wrote: > On 2/2/21 3:28 PM, Kevin Wolf wrote: >> If the qemu-system-{arch} binary for the host architecture can't be >> found, the old 'check' implementation sel

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Philippe Mathieu-Daudé
On 2/2/21 3:28 PM, Kevin Wolf wrote: > If the qemu-system-{arch} binary for the host architecture can't be > found, the old 'check' implementation selected the alphabetically first > system emulator binary that it could find. The new Python implementation > just uses the first result of glob.iglob(

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Kevin Wolf
Am 02.02.2021 um 15:41 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 02, 2021 at 03:28:02PM +0100, Kevin Wolf wrote: > > If the qemu-system-{arch} binary for the host architecture can't be > > found, the old 'check' implementation selected the alphabetically first > > system emulator binary tha

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 03:28:02PM +0100, Kevin Wolf wrote: > If the qemu-system-{arch} binary for the host architecture can't be > found, the old 'check' implementation selected the alphabetically first > system emulator binary that it could find. The new Python implementation > just uses the firs

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Philippe Mathieu-Daudé
On 2/2/21 3:28 PM, Kevin Wolf wrote: > If the qemu-system-{arch} binary for the host architecture can't be > found, the old 'check' implementation selected the alphabetically first > system emulator binary that it could find. The new Python implementation > just uses the first result of glob.iglob(

[PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Kevin Wolf
If the qemu-system-{arch} binary for the host architecture can't be found, the old 'check' implementation selected the alphabetically first system emulator binary that it could find. The new Python implementation just uses the first result of glob.iglob(), which has an undefined order. This is a p