Re: [PATCH] iotests/check: move general long options to double dash

2021-06-07 Thread Eric Blake
On Fri, Jun 04, 2021 at 11:25:16AM +0300, Vladimir Sementsov-Ogievskiy wrote: > So, there are some ways to improve the situation: My personal preference (although I'm fine with any of your listed options, if others speak up in favor of a different one): > 2. Take this patch and also convert proto

Re: [PATCH] iotests/check: move general long options to double dash

2021-06-04 Thread Vladimir Sementsov-Ogievskiy
04.06.2021 10:19, Paolo Bonzini wrote: On 03/06/21 14:19, Vladimir Sementsov-Ogievskiy wrote: Double-dash options give extra information to the user that short (single-dash) options can be combined, while this is not the case for iotests/check. You can combine short options for check script,

Re: [PATCH] iotests/check: move general long options to double dash

2021-06-04 Thread Paolo Bonzini
On 03/06/21 14:19, Vladimir Sementsov-Ogievskiy wrote: Double-dash options give extra information to the user that short (single-dash) options can be combined, while this is not the case for iotests/check. You can combine short options for check script, as argparse supports it. We don't hav

Re: [PATCH] iotests/check: move general long options to double dash

2021-06-03 Thread Vladimir Sementsov-Ogievskiy
03.06.2021 14:38, Paolo Bonzini wrote: On 26/05/21 20:16, Vladimir Sementsov-Ogievskiy wrote: So, the change:    -makecheck -> --makecheck    -valgrind  -> --valgrind    -nocache   -> --nocache    -misalign  -> --misalign Motivation: 1. Several long options are already have double dash:    --

Re: [PATCH] iotests/check: move general long options to double dash

2021-06-03 Thread Vladimir Sementsov-Ogievskiy
03.06.2021 13:21, Emanuele Giuseppe Esposito wrote: On 26/05/2021 20:16, Vladimir Sementsov-Ogievskiy wrote: So, the change:    -makecheck -> --makecheck    -valgrind  -> --valgrind    -nocache   -> --nocache    -misalign  -> --misalign Motivation: 1. Several long options are already have d

Re: [PATCH] iotests/check: move general long options to double dash

2021-06-03 Thread Paolo Bonzini
On 26/05/21 20:16, Vladimir Sementsov-Ogievskiy wrote: So, the change: -makecheck -> --makecheck -valgrind -> --valgrind -nocache -> --nocache -misalign -> --misalign Motivation: 1. Several long options are already have double dash: --dry-run, --color, --groups, --exclude-gr

Re: [PATCH] iotests/check: move general long options to double dash

2021-06-03 Thread Emanuele Giuseppe Esposito
On 26/05/2021 20:16, Vladimir Sementsov-Ogievskiy wrote: So, the change: -makecheck -> --makecheck -valgrind -> --valgrind -nocache -> --nocache -misalign -> --misalign Motivation: 1. Several long options are already have double dash: --dry-run, --color, --groups, --exclu

[PATCH] iotests/check: move general long options to double dash

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
So, the change: -makecheck -> --makecheck -valgrind -> --valgrind -nocache -> --nocache -misalign -> --misalign Motivation: 1. Several long options are already have double dash: --dry-run, --color, --groups, --exclude-groups, --start-from 2. -misalign is used to add --misalign opt