Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On 28/11/24 20:06, Phil Dennis-Jordan wrote: On Thu, 28 Nov 2024 at 17:46, Philippe Mathieu-Daudé > wrote: On 28/11/24 17:38, Phil Dennis-Jordan wrote: > Paolo, could we please apply either Sairaj and Santosh's fix at > https://patchew.org/QEMU/20241114114

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On Thu, 28 Nov 2024 at 17:46, Philippe Mathieu-Daudé wrote: > On 28/11/24 17:38, Phil Dennis-Jordan wrote: > > Paolo, could we please apply either Sairaj and Santosh's fix at > > https://patchew.org/QEMU/20241114114509.15350-1-sarun...@amd.com/ > >

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On 28/11/24 17:38, Phil Dennis-Jordan wrote: Paolo, could we please apply either Sairaj and Santosh's fix at https://patchew.org/QEMU/20241114114509.15350-1-sarun...@amd.com/ or mine to fix this link error? As neither patch has

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

Paolo, could we please apply either Sairaj and Santosh's fix at https://patchew.org/QEMU/20241114114509.15350-1-sarun...@amd.com/ or mine to fix this link error? As neither patch has so far been merged, 9.2.0-rc2 still fails to build on macOS, at least on my local systems. I'm not sure why CI build

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On 11/13/2024 11:41 PM, Paolo Bonzini wrote: > On 11/13/24 15:49, Phil Dennis-Jordan wrote: >> It appears that existing call sites for the kvm_enable_x2apic() >> function rely on the compiler eliding the calls during optimisation >> when building with KVM disabled, or on platforms other than Lin

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On 11/13/24 15:49, Phil Dennis-Jordan wrote: It appears that existing call sites for the kvm_enable_x2apic() function rely on the compiler eliding the calls during optimisation when building with KVM disabled, or on platforms other than Linux, where that function is declared but not defined. Thi

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On 11/14/2024 12:09 AM, Paolo Bonzini wrote: > On Wed, Nov 13, 2024 at 7:25 PM Shukla, Santosh > wrote: >> Same proposed at >> https://lore.kernel.org/qemu-devel/cebca38a-5896-e2a5-8a68-5edad5dc9...@amd.com/ >> and I think Phil confirmed that it works. > > Thanks Santosh, can you post it wit

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On Wed, Nov 13, 2024 at 7:25 PM Shukla, Santosh wrote: > Same proposed at > https://lore.kernel.org/qemu-devel/cebca38a-5896-e2a5-8a68-5edad5dc9...@amd.com/ > and I think Phil confirmed that it works. Thanks Santosh, can you post it with commit message and everything? Paolo

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On Wed 13. Nov 2024 at 19:06, Paolo Bonzini wrote: > On 11/13/24 15:49, Phil Dennis-Jordan wrote: > > It appears that existing call sites for the kvm_enable_x2apic() > > function rely on the compiler eliding the calls during optimisation > > when building with KVM disabled, or on platforms other

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

On 11/13/24 15:49, Phil Dennis-Jordan wrote: It appears that existing call sites for the kvm_enable_x2apic() function rely on the compiler eliding the calls during optimisation when building with KVM disabled, or on platforms other than Linux, where that function is declared but not defined. Thi

[PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

It appears that existing call sites for the kvm_enable_x2apic() function rely on the compiler eliding the calls during optimisation when building with KVM disabled, or on platforms other than Linux, where that function is declared but not defined. This fragile reliance recently broke down when com