Re: [PATCH] hw/virtio/vdpa-dev: Check returned value instead of dereferencing @errp

2024-07-16 Thread Eugenio Perez Martin
On Tue, Jul 16, 2024 at 5:05 AM Zhao Liu wrote: > > On Mon, Jul 15, 2024 at 11:01:08PM +0200, Eugenio Perez Martin wrote: > > Date: Mon, 15 Jul 2024 23:01:08 +0200 > > From: Eugenio Perez Martin > > Subject: Re: [PATCH] hw/virtio/vdpa-dev: Check returned value instead of

Re: [PATCH] hw/virtio/vdpa-dev: Check returned value instead of dereferencing @errp

2024-07-15 Thread Zhao Liu
On Mon, Jul 15, 2024 at 11:01:08PM +0200, Eugenio Perez Martin wrote: > Date: Mon, 15 Jul 2024 23:01:08 +0200 > From: Eugenio Perez Martin > Subject: Re: [PATCH] hw/virtio/vdpa-dev: Check returned value instead of > dereferencing @errp > > On Mon, Jul 15, 2024 at 11:45 

Re: [PATCH] hw/virtio/vdpa-dev: Check returned value instead of dereferencing @errp

2024-07-15 Thread Eugenio Perez Martin
On Mon, Jul 15, 2024 at 11:45 AM Zhao Liu wrote: > > As the comment in qapi/error, dereferencing @errp requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > * - It must not be dereferenced, because it may

[PATCH] hw/virtio/vdpa-dev: Check returned value instead of dereferencing @errp

2024-07-15 Thread Zhao Liu
As the comment in qapi/error, dereferencing @errp requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: * - It must not be dereferenced, because it may be null. ... * ERRP_GUARD() lifts these restrictions. * * To use