Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-27 Thread Corey Minyard
On Thu, Jan 27, 2022 at 03:18:43PM -0800, Patrick Venture wrote: > On Thu, Jan 27, 2022 at 10:20 AM Hao Wu wrote: > > > > > On Thu, Jan 27, 2022 at 6:55 AM Corey Minyard wrote: > > > >> On Wed, Jan 26, 2022 at 04:09:03PM -0800, Hao Wu wrote: > >> > Hi, > >> > > >> > Sorry for the late reply. I'm

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-27 Thread Patrick Venture
On Thu, Jan 27, 2022 at 10:20 AM Hao Wu wrote: > > On Thu, Jan 27, 2022 at 6:55 AM Corey Minyard wrote: > >> On Wed, Jan 26, 2022 at 04:09:03PM -0800, Hao Wu wrote: >> > Hi, >> > >> > Sorry for the late reply. I'm not sure what "auto-increment" means here. >> >> The question is: When a value is

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-27 Thread Hao Wu
On Thu, Jan 27, 2022 at 6:55 AM Corey Minyard wrote: > On Wed, Jan 26, 2022 at 04:09:03PM -0800, Hao Wu wrote: > > Hi, > > > > Sorry for the late reply. I'm not sure what "auto-increment" means here. > > The question is: When a value is read, does the address automatically > increment. I2C devic

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-27 Thread Corey Minyard
On Wed, Jan 26, 2022 at 04:09:03PM -0800, Hao Wu wrote: > Hi, > > Sorry for the late reply. I'm not sure what "auto-increment" means here. The question is: When a value is read, does the address automatically increment. I2C devices very often do this. If you do a multi-byte read, they often wil

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-26 Thread Hao Wu
Hi, Sorry for the late reply. I'm not sure what "auto-increment" means here. The kernel driver at https://lkml.org/lkml/2020/12/11/968 only has byte-size read/write operations, so I don't see a problem here. The values are extracted from the datasheet. On Tue, Jan 18, 2022 at 9:10 AM Patrick Vent

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-18 Thread Patrick Venture
On Mon, Jan 17, 2022 at 6:05 AM Corey Minyard wrote: > On Sun, Jan 09, 2022 at 06:17:34PM -0800, Patrick Venture wrote: > > On Fri, Jan 7, 2022 at 7:04 PM Patrick Venture > wrote: > > > > > From: Hao Wu > > > > > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > > > interface

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-17 Thread Corey Minyard
On Sun, Jan 09, 2022 at 06:17:34PM -0800, Patrick Venture wrote: > On Fri, Jan 7, 2022 at 7:04 PM Patrick Venture wrote: > > > From: Hao Wu > > > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > > interface that reports AMD SoC's Ttcl (normalized temperature), > > and resemble

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-12 Thread Thomas Huth
On 10/01/2022 10.35, Philippe Mathieu-Daudé wrote: Hi Patrick, On 1/8/22 04:04, Patrick Venture wrote: From: Hao Wu SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible interface that reports AMD SoC's Ttcl (normalized temperature), and resembles a typical 8-pin remote temperature

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-10 Thread Patrick Venture
On Mon, Jan 10, 2022 at 11:30 AM Philippe Mathieu-Daudé wrote: > On 1/10/22 18:14, Patrick Venture wrote: > > On Mon, Jan 10, 2022 at 1:35 AM Philippe Mathieu-Daudé > > wrote: > > > > Hi Patrick, > > > > On 1/8/22 04:04, Patrick Venture wrote: > > > From: Hao

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 18:14, Patrick Venture wrote: > On Mon, Jan 10, 2022 at 1:35 AM Philippe Mathieu-Daudé > wrote: > > Hi Patrick, > > On 1/8/22 04:04, Patrick Venture wrote: > > From: Hao Wu mailto:wuhao...@google.com>> > > > > SB Temperature Sensor Interface

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-10 Thread Patrick Venture
On Mon, Jan 10, 2022 at 1:35 AM Philippe Mathieu-Daudé wrote: > Hi Patrick, > > On 1/8/22 04:04, Patrick Venture wrote: > > From: Hao Wu > > > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > > interface that reports AMD SoC's Ttcl (normalized temperature), > > and resembles a

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-10 Thread Philippe Mathieu-Daudé
Hi Patrick, On 1/8/22 04:04, Patrick Venture wrote: > From: Hao Wu > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > interface that reports AMD SoC's Ttcl (normalized temperature), > and resembles a typical 8-pin remote temperature sensor's I2C interface > to BMC. > > This p

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-09 Thread Patrick Venture
On Fri, Jan 7, 2022 at 7:04 PM Patrick Venture wrote: > From: Hao Wu > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > interface that reports AMD SoC's Ttcl (normalized temperature), > and resembles a typical 8-pin remote temperature sensor's I2C interface > to BMC. > > This

[PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-07 Thread Patrick Venture
From: Hao Wu SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible interface that reports AMD SoC's Ttcl (normalized temperature), and resembles a typical 8-pin remote temperature sensor's I2C interface to BMC. This patch implements a basic AMD SB-TSI sensor that is compatible with the

[PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2021-08-12 Thread Hao Wu
SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible interface that reports AMD SoC's Ttcl (normalized temperature), and resembles a typical 8-pin remote temperature sensor's I2C interface to BMC. This patch implements a basic AMD SB-TSI sensor that is compatible with the open-source da