Re: [PATCH] hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio

2021-05-24 Thread Kit Westneat
I started looking into adding tests, but it doesn't look like blkdebug supports changing the blocksize. I saw that it supports changing the memory alignment to 4k via the align parameter, but it doesn't implement bdrv_probe_blocksizes so the blocksize stays at 512. Would it be worth adding a block

Re: [PATCH] hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio

2021-05-21 Thread Paolo Bonzini
On 21/05/21 16:28, Kit Westneat wrote: check_lba_range expects sectors to be expressed in original qdev blocksize, but scsi_unmap_complete_noio was translating them to 512 block sizes, which was causing sense errors in the larger LBAs in devices using a 4k block size. Resolves: https://gitlab.co

[PATCH] hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio

2021-05-21 Thread Kit Westneat
check_lba_range expects sectors to be expressed in original qdev blocksize, but scsi_unmap_complete_noio was translating them to 512 block sizes, which was causing sense errors in the larger LBAs in devices using a 4k block size. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/345 Signed-o