Re: [PATCH] hw/rtc/pl031: Send RTC_CHANGE QMP event

2021-09-20 Thread Eric Auger
Hi Peter, On 9/16/21 8:24 PM, Peter Maydell wrote: > On Thu, 16 Sept 2021 at 18:19, Eric Auger wrote: >> Hi Peter, >> On 9/16/21 3:32 PM, Peter Maydell wrote: >>> None of the other users of qapi_event_send_rtc_change() >>> seem to have to track the baseline time like this. Shouldn't >>> this be d

Re: [PATCH] hw/rtc/pl031: Send RTC_CHANGE QMP event

2021-09-16 Thread Peter Maydell
On Thu, 16 Sept 2021 at 18:19, Eric Auger wrote: > > Hi Peter, > On 9/16/21 3:32 PM, Peter Maydell wrote: > > None of the other users of qapi_event_send_rtc_change() > > seem to have to track the baseline time like this. Shouldn't > > this be doing something involving using qemu_ref_timedate() > >

Re: [PATCH] hw/rtc/pl031: Send RTC_CHANGE QMP event

2021-09-16 Thread Eric Auger
Hi Peter, On 9/16/21 3:32 PM, Peter Maydell wrote: > On Thu, 9 Sept 2021 at 13:24, Eric Auger wrote: >> The PL031 currently is not able to report guest RTC change to the QMP >> monitor as opposed to mc146818 or spapr RTCs. This patch adds the call >> to qapi_event_send_rtc_change() when the Load R

Re: [PATCH] hw/rtc/pl031: Send RTC_CHANGE QMP event

2021-09-16 Thread Peter Maydell
On Thu, 9 Sept 2021 at 13:24, Eric Auger wrote: > > The PL031 currently is not able to report guest RTC change to the QMP > monitor as opposed to mc146818 or spapr RTCs. This patch adds the call > to qapi_event_send_rtc_change() when the Load Register is written. The > value that is reported corre

[PATCH] hw/rtc/pl031: Send RTC_CHANGE QMP event

2021-09-09 Thread Eric Auger
The PL031 currently is not able to report guest RTC change to the QMP monitor as opposed to mc146818 or spapr RTCs. This patch adds the call to qapi_event_send_rtc_change() when the Load Register is written. The value that is reported corresponds to the difference between the new RTC value and the