Re: [PATCH] hw/registerfields: Prefix local variables with underscore in macros

2020-05-27 Thread Philippe Mathieu-Daudé
Hi Alistair, On 5/27/20 12:49 AM, Alistair Francis wrote: > On Tue, May 26, 2020 at 9:50 AM Philippe Mathieu-Daudé > wrote: >> >> ping? > > I'll send a PR with this. Well, this was only a "friendly ping", there is no hurry, I can wait for the next qemu-trivial pull request. Thanks! Phil. >

Re: [PATCH] hw/registerfields: Prefix local variables with underscore in macros

2020-05-26 Thread Alistair Francis
On Tue, May 26, 2020 at 9:50 AM Philippe Mathieu-Daudé wrote: > > ping? I'll send a PR with this. Alistair > > On 5/10/20 10:34 PM, Philippe Mathieu-Daudé wrote: > > One can name a local variable holding a value as 'v', but it > > currently clashes with the registerfields macros. To save others

Re: [PATCH] hw/registerfields: Prefix local variables with underscore in macros

2020-05-26 Thread Philippe Mathieu-Daudé
ping? On 5/10/20 10:34 PM, Philippe Mathieu-Daudé wrote: > One can name a local variable holding a value as 'v', but it > currently clashes with the registerfields macros. To save others > to debug the same mistake, prefix the macro's local variables > with an underscore. > > Signed-off-by: Phili

Re: [PATCH] hw/registerfields: Prefix local variables with underscore in macros

2020-05-11 Thread Alistair Francis
On Sun, May 10, 2020 at 1:35 PM Philippe Mathieu-Daudé wrote: > > One can name a local variable holding a value as 'v', but it > currently clashes with the registerfields macros. To save others > to debug the same mistake, prefix the macro's local variables > with an underscore. > > Signed-off-by:

[PATCH] hw/registerfields: Prefix local variables with underscore in macros

2020-05-10 Thread Philippe Mathieu-Daudé
One can name a local variable holding a value as 'v', but it currently clashes with the registerfields macros. To save others to debug the same mistake, prefix the macro's local variables with an underscore. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/registerfields.h | 40 +