Re: [PATCH] hw/ppc/openpic: Do not open-code ROUND_UP() macro

2023-06-06 Thread Daniel Henrique Barboza
On 5/23/23 03:15, Philippe Mathieu-Daudé wrote: While reviewing, the ROUND_UP() macro is easier to figure out. Besides, the comment confirms we want to round up here. Signed-off-by: Philippe Mathieu-Daudé --- Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel include/h

Re: [PATCH] hw/ppc/openpic: Do not open-code ROUND_UP() macro

2023-06-02 Thread Philippe Mathieu-Daudé
There is no generic PPC section in MAINTAINERS covering include/hw/ppc/, so Cc'ing qemu-ppc@ manually. Daniel, can you take this (reviewed) patch? Thanks, Phil. On 23/5/23 08:15, Philippe Mathieu-Daudé wrote: While reviewing, the ROUND_UP() macro is easier to figure out. Besides, the comment

Re: [PATCH] hw/ppc/openpic: Do not open-code ROUND_UP() macro

2023-05-25 Thread Mark Cave-Ayland
On 23/05/2023 07:15, Philippe Mathieu-Daudé wrote: While reviewing, the ROUND_UP() macro is easier to figure out. Besides, the comment confirms we want to round up here. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ppc/openpic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] hw/ppc/openpic: Do not open-code ROUND_UP() macro

2023-05-23 Thread Richard Henderson
On 5/22/23 23:15, Philippe Mathieu-Daudé wrote: While reviewing, the ROUND_UP() macro is easier to figure out. Besides, the comment confirms we want to round up here. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ppc/openpic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Rev

[PATCH] hw/ppc/openpic: Do not open-code ROUND_UP() macro

2023-05-22 Thread Philippe Mathieu-Daudé
While reviewing, the ROUND_UP() macro is easier to figure out. Besides, the comment confirms we want to round up here. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ppc/openpic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/ppc/openpic.h b/include/hw/ppc/