Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-22 Thread David Gibson
On Mon, Mar 22, 2021 at 01:48:07PM +0800, Bin Meng wrote: > Hi David, > > On Mon, Mar 22, 2021 at 1:24 PM David Gibson > wrote: > > > > On Mon, Mar 22, 2021 at 12:33:06PM +0800, Bin Meng wrote: > > > Hi David, > > > > > > On Mon, Mar 22, 2021 at 12:11 PM David Gibson > > > wrote: > > > > > > > >

Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-22 Thread David Gibson
On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote: > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", > min_frame_len should excluce CRC, so it should be 60 instead of 64. > > Signed-off-by: Bin Meng Applied to ppc-for-6.0, thanks. > --- > > hw/net/fsl_etsec/rings.

Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-21 Thread Bin Meng
Hi David, On Mon, Mar 22, 2021 at 1:24 PM David Gibson wrote: > > On Mon, Mar 22, 2021 at 12:33:06PM +0800, Bin Meng wrote: > > Hi David, > > > > On Mon, Mar 22, 2021 at 12:11 PM David Gibson > > wrote: > > > > > > On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote: > > > > As the comment

Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-21 Thread David Gibson
On Mon, Mar 22, 2021 at 12:33:06PM +0800, Bin Meng wrote: > Hi David, > > On Mon, Mar 22, 2021 at 12:11 PM David Gibson > wrote: > > > > On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote: > > > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", > > > min_frame_len should

Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-21 Thread Bin Meng
Hi David, On Mon, Mar 22, 2021 at 12:11 PM David Gibson wrote: > > On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote: > > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", > > min_frame_len should excluce CRC, so it should be 60 instead of 64. > > Sorry, your reasoning

Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-21 Thread David Gibson
On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote: > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", > min_frame_len should excluce CRC, so it should be 60 instead of 64. Sorry, your reasoning still isn't clear to me. If qemu is not adding the CRC, what is? Will it a

Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-21 Thread David Gibson
On Mon, Mar 22, 2021 at 09:29:12AM +0800, Bin Meng wrote: > On Tue, Mar 16, 2021 at 4:15 PM Bin Meng wrote: > > > > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", > > min_frame_len should excluce CRC, so it should be 60 instead of 64. > > > > Signed-off-by: Bin Meng > > ---

Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-21 Thread Bin Meng
On Tue, Mar 16, 2021 at 4:15 PM Bin Meng wrote: > > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", > min_frame_len should excluce CRC, so it should be 60 instead of 64. > > Signed-off-by: Bin Meng > --- > > hw/net/fsl_etsec/rings.c | 2 +- > 1 file changed, 1 insertion(+),

[PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-16 Thread Bin Meng
As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", min_frame_len should excluce CRC, so it should be 60 instead of 64. Signed-off-by: Bin Meng --- hw/net/fsl_etsec/rings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fs