Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/27 12:24, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:11 AM Akihiko Odaki wrote: On 2024/03/27 12:06, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote: On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On 2024

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 11:11 AM Akihiko Odaki wrote: > > On 2024/03/27 12:06, Jason Wang wrote: > > On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki > > wrote: > >> > >> On 2024/03/27 11:59, Jason Wang wrote: > >>> On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki > >>> wrote: > > On 202

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/27 12:06, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote: On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On 2024/

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote: > > On 2024/03/27 11:59, Jason Wang wrote: > > On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki > > wrote: > >> > >> On 2024/03/27 11:50, Jason Wang wrote: > >>> On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki > >>> wrote: > > On 2024

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is inc

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: > > On 2024/03/27 11:50, Jason Wang wrote: > > On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki > > wrote: > >> > >> On 2024/03/26 15:51, Jason Wang wrote: > >>> On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki > >>> wrote: > > It is in

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when checksum offloading is disabled so clear

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Jason Wang
On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: > > On 2024/03/26 15:51, Jason Wang wrote: > > On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki > > wrote: > >> > >> It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when > >> checksum offloading is disabled so clear the bit. Set the >

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when checksum offloading is disabled so clear the bit. Set the VIRTIO_NET_HDR_F_DATA_VALID bit instead to tell the checksum is valid. TCP/UDP

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-25 Thread Jason Wang
On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: > > It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when > checksum offloading is disabled so clear the bit. Set the > VIRTIO_NET_HDR_F_DATA_VALID bit instead to tell the checksum is valid. > > TCP/UDP checksum is usually offloaded w

[PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-24 Thread Akihiko Odaki
It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when checksum offloading is disabled so clear the bit. Set the VIRTIO_NET_HDR_F_DATA_VALID bit instead to tell the checksum is valid. TCP/UDP checksum is usually offloaded when the peer requires virtio headers because they can instruct th