RE: [PATCH] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-02-25 Thread Chenqun (kuhn)
>-Original Message- >From: Jason Wang [mailto:jasow...@redhat.com] >Sent: Wednesday, February 26, 2020 11:03 AM >To: Peter Maydell >Cc: Chenqun (kuhn) ; QEMU Developers >; QEMU Trivial ; >Zhanghailiang ; Peter Chubb >; qemu-arm >Subject: Re: [PATCH] hw/net/im

Re: [PATCH] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-02-25 Thread Jason Wang
On 2020/2/25 下午6:18, Peter Maydell wrote: On Tue, 25 Feb 2020 at 05:41, Jason Wang wrote: On 2020/2/25 上午10:59, Chen Qun wrote: The current code causes clang static code analyzer generate warning: hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read value = value

Re: [PATCH] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-02-25 Thread Peter Maydell
On Tue, 25 Feb 2020 at 05:41, Jason Wang wrote: > > > On 2020/2/25 上午10:59, Chen Qun wrote: > > The current code causes clang static code analyzer generate warning: > > hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read > > value = value & 0x000f; > > ^

Re: [PATCH] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-02-24 Thread Jason Wang
On 2020/2/25 上午10:59, Chen Qun wrote: The current code causes clang static code analyzer generate warning: hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read value = value & 0x000f; ^ ~~ hw/net/imx_fec.c:864:9: warning: Value store

[PATCH] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-02-24 Thread Chen Qun
The current code causes clang static code analyzer generate warning: hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read value = value & 0x000f; ^ ~~ hw/net/imx_fec.c:864:9: warning: Value stored to 'value' is never read value = v