Re: [PATCH] hw/misc/npcm_clk: fix buffer-overflow

2025-03-17 Thread Thomas Huth
On 26/02/2025 21.50, Peter Maydell wrote: (edited cc list since it's moved away from a discussion of this particular patch and on to a testing/ci coverage issue) On Wed, 26 Feb 2025 at 19:03, Pierrick Bouvier wrote: On 2/26/25 03:50, Peter Maydell wrote: On Tue, 25 Feb 2025 at 20:57, Pierric

Re: [PATCH] hw/misc/npcm_clk: fix buffer-overflow

2025-02-26 Thread Peter Maydell
(edited cc list since it's moved away from a discussion of this particular patch and on to a testing/ci coverage issue) On Wed, 26 Feb 2025 at 19:03, Pierrick Bouvier wrote: > > On 2/26/25 03:50, Peter Maydell wrote: > > On Tue, 25 Feb 2025 at 20:57, Pierrick Bouvier > > wrote: > >> > >> On 2/25

Re: [PATCH] hw/misc/npcm_clk: fix buffer-overflow

2025-02-26 Thread Pierrick Bouvier
On 2/26/25 03:50, Peter Maydell wrote: On Tue, 25 Feb 2025 at 20:57, Pierrick Bouvier wrote: On 2/25/25 05:41, Peter Maydell wrote: (Looking more closely at the cold_reset_values handling in npcm_gcr.c, that looks not quite right in a different way; I'll send a reply to that patch email about

Re: [PATCH] hw/misc/npcm_clk: fix buffer-overflow

2025-02-26 Thread Peter Maydell
On Tue, 25 Feb 2025 at 20:57, Pierrick Bouvier wrote: > > On 2/25/25 05:41, Peter Maydell wrote: > > (Looking more closely at the cold_reset_values handling > > in npcm_gcr.c, that looks not quite right in a different > > way; I'll send a reply to that patch email about that.) > > > > It may be a

Re: [PATCH] hw/misc/npcm_clk: fix buffer-overflow

2025-02-25 Thread Pierrick Bouvier
On 2/25/25 05:41, Peter Maydell wrote: On Mon, 24 Feb 2025 at 20:51, Pierrick Bouvier wrote: Regression introduced by cf76c4 (hw/misc: Add nr_regs and cold_reset_values to NPCM CLK) cold_reset_values has a different size, depending on device used (NPCM7xx vs NPCM8xx). However, s->regs has a f

Re: [PATCH] hw/misc/npcm_clk: fix buffer-overflow

2025-02-25 Thread Peter Maydell
On Mon, 24 Feb 2025 at 20:51, Pierrick Bouvier wrote: > > Regression introduced by cf76c4 > (hw/misc: Add nr_regs and cold_reset_values to NPCM CLK) > > cold_reset_values has a different size, depending on device used > (NPCM7xx vs NPCM8xx). However, s->regs has a fixed size, which matches > NPCM8

Re: [PATCH] hw/misc/npcm_clk: fix buffer-overflow

2025-02-24 Thread Hao Wu
Thanks! On Mon, Feb 24, 2025 at 12:51 PM Pierrick Bouvier < pierrick.bouv...@linaro.org> wrote: > Regression introduced by cf76c4 > (hw/misc: Add nr_regs and cold_reset_values to NPCM CLK) > > cold_reset_values has a different size, depending on device used > (NPCM7xx vs NPCM8xx). However, s->reg

[PATCH] hw/misc/npcm_clk: fix buffer-overflow

2025-02-24 Thread Pierrick Bouvier
Regression introduced by cf76c4 (hw/misc: Add nr_regs and cold_reset_values to NPCM CLK) cold_reset_values has a different size, depending on device used (NPCM7xx vs NPCM8xx). However, s->regs has a fixed size, which matches NPCM8xx. Thus, when initializing a NPCM7xx, we go past cold_reset_values