Re: [RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-19 Thread Pankaj Gupta
> In the ACPI specification [1], the 'unarmed' bit is set when a device > cannot accept a persistent write. This means that when a memdev is > read-only, the 'unarmed' flag must be turned on. The logic is correct, > just changing the error message. > > [1] ACPI NFIT NVDIMM Region Mapping Structure

Re: [RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-19 Thread Julia Suvorova
On Tue, Oct 18, 2022 at 6:49 PM Michael S. Tsirkin wrote: > > On Tue, Oct 18, 2022 at 06:17:55PM +0200, Philippe Mathieu-Daudé wrote: > > On 18/10/22 17:25, Julia Suvorova wrote: > > > In the ACPI specification [1], the 'unarmed' bit is set when a device > > > cannot accept a persistent write. Thi

Re: [RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-19 Thread David Hildenbrand
On 18.10.22 18:49, Michael S. Tsirkin wrote: On Tue, Oct 18, 2022 at 06:17:55PM +0200, Philippe Mathieu-Daudé wrote: On 18/10/22 17:25, Julia Suvorova wrote: In the ACPI specification [1], the 'unarmed' bit is set when a device cannot accept a persistent write. This means that when a memdev is

Re: [RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-18 Thread Michael S. Tsirkin
On Tue, Oct 18, 2022 at 06:17:55PM +0200, Philippe Mathieu-Daudé wrote: > On 18/10/22 17:25, Julia Suvorova wrote: > > In the ACPI specification [1], the 'unarmed' bit is set when a device > > cannot accept a persistent write. This means that when a memdev is > > read-only, the 'unarmed' flag must

Re: [RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-18 Thread Philippe Mathieu-Daudé
On 18/10/22 17:25, Julia Suvorova wrote: In the ACPI specification [1], the 'unarmed' bit is set when a device cannot accept a persistent write. This means that when a memdev is read-only, the 'unarmed' flag must be turned on. The logic is correct, just changing the error message. [1] ACPI NFIT

[RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-18 Thread Julia Suvorova
In the ACPI specification [1], the 'unarmed' bit is set when a device cannot accept a persistent write. This means that when a memdev is read-only, the 'unarmed' flag must be turned on. The logic is correct, just changing the error message. [1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM Sta

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-17 Thread Xiao Guangrong
On Wed, Jun 15, 2022 at 7:49 PM David Hildenbrand wrote: > > On 15.06.22 13:17, Xiao Guangrong wrote: > > On Wed, Jun 15, 2022 at 4:24 PM David Hildenbrand wrote: > > > Is that a temporary or a permanent thing? Do we know? > >>> > >>> No idea. But his last signed-off was three years ago. > >

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-15 Thread David Hildenbrand
On 15.06.22 13:17, Xiao Guangrong wrote: > On Wed, Jun 15, 2022 at 4:24 PM David Hildenbrand wrote: > Is that a temporary or a permanent thing? Do we know? >>> >>> No idea. But his last signed-off was three years ago. >> >> I sent a patch to Xiao, asking if he's still active in QEMU. If I do

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-15 Thread Xiao Guangrong
On Wed, Jun 15, 2022 at 4:24 PM David Hildenbrand wrote: > >> Is that a temporary or a permanent thing? Do we know? > > > > No idea. But his last signed-off was three years ago. > > I sent a patch to Xiao, asking if he's still active in QEMU. If I don't > get a reply this week, I'll move forward

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-15 Thread David Hildenbrand
On 14.06.22 14:13, Julia Suvorova wrote: > On Tue, Jun 14, 2022 at 11:50 AM David Hildenbrand wrote: >> >> On 14.06.22 10:54, Igor Mammedov wrote: >>> On Mon, 13 Jun 2022 16:09:53 +0100 >>> Stefan Hajnoczi wrote: >>> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > On Tu

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread Igor Mammedov
On Tue, 14 Jun 2022 11:50:43 +0200 David Hildenbrand wrote: > On 14.06.22 10:54, Igor Mammedov wrote: > > On Mon, 13 Jun 2022 16:09:53 +0100 > > Stefan Hajnoczi wrote: > > > >> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > >>> On Tue, May 31, 2022 at 5:32 PM Stefan Hajno

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread Julia Suvorova
On Tue, Jun 14, 2022 at 11:50 AM David Hildenbrand wrote: > > On 14.06.22 10:54, Igor Mammedov wrote: > > On Mon, 13 Jun 2022 16:09:53 +0100 > > Stefan Hajnoczi wrote: > > > >> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > >>> On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread David Hildenbrand
On 14.06.22 10:54, Igor Mammedov wrote: > On Mon, 13 Jun 2022 16:09:53 +0100 > Stefan Hajnoczi wrote: > >> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: >>> On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi >>> wrote: On Tue, May 31, 2022 at 04:51:47PM +0200, Julia S

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread Igor Mammedov
On Mon, 13 Jun 2022 16:09:53 +0100 Stefan Hajnoczi wrote: > On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > > On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi > > wrote: > > > > > > On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote: > > > > In the ACPI specific

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-13 Thread Stefan Hajnoczi
On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi wrote: > > > > On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote: > > > In the ACPI specification [1], the 'unarmed' bit is set when a device > > > cannot accept a persist

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-13 Thread Julia Suvorova
On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi wrote: > > On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote: > > In the ACPI specification [1], the 'unarmed' bit is set when a device > > cannot accept a persistent write. This means that when a memdev is > > read-only, the 'unarmed' f

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-05-31 Thread Stefan Hajnoczi
On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote: > In the ACPI specification [1], the 'unarmed' bit is set when a device > cannot accept a persistent write. This means that when a memdev is > read-only, the 'unarmed' flag must be turned on. The logic is correct, > just changing the e

[PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-05-31 Thread Julia Suvorova
In the ACPI specification [1], the 'unarmed' bit is set when a device cannot accept a persistent write. This means that when a memdev is read-only, the 'unarmed' flag must be turned on. The logic is correct, just changing the error message. [1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM Sta