Re: [PATCH] hw/intc/arm_gicv3: Fix GICv3 redistributor security checking

2021-07-17 Thread Tianrui Wei
Hi Peter, Many thanks for your detailed explanation. Upon further reflection, it seems that I have misinterpreted some of the explanations in the manual. Sorry for the confusion, the original implementation is correct. Thanks, Tianrui On Fri, Jul 16, 2021 at 4:32 PM Peter Maydell wrote: > On W

Re: [PATCH] hw/intc/arm_gicv3: Fix GICv3 redistributor security checking

2021-07-16 Thread Peter Maydell
On Wed, 14 Jul 2021 at 20:46, Tianrui Wei wrote: > > For redistributor to send sgi, we must test NSACR bits in secure mode. > However, current implementation inverts the security check, wrongly > skipping this it when the CPU is in secure state, and only carrying out > the check when the CPU is no

[PATCH] hw/intc/arm_gicv3: Fix GICv3 redistributor security checking

2021-07-14 Thread Tianrui Wei
For redistributor to send sgi, we must test NSACR bits in secure mode. However, current implementation inverts the security check, wrongly skipping this it when the CPU is in secure state, and only carrying out the check when the CPU is not secure or security is not implemented. This patch corrects