Re: [PATCH] hw/intc/arm_gic_kvm: Don't assume kernel can provide a GICv2

2020-02-26 Thread Auger Eric
Hi Peter, On 2/26/20 12:58 PM, Auger Eric wrote: > Hi Peter, > > On 2/26/20 10:17 AM, Andrew Jones wrote: >> On Wed, Feb 26, 2020 at 08:56:03AM +, Peter Maydell wrote: >>> On Wed, 26 Feb 2020 at 08:52, Andrew Jones wrote: Although, many QEMU command line users still won't know what to d

Re: [PATCH] hw/intc/arm_gic_kvm: Don't assume kernel can provide a GICv2

2020-02-26 Thread Auger Eric
Hi Peter, On 2/26/20 10:17 AM, Andrew Jones wrote: > On Wed, Feb 26, 2020 at 08:56:03AM +, Peter Maydell wrote: >> On Wed, 26 Feb 2020 at 08:52, Andrew Jones wrote: >>> Although, many QEMU command line users still won't know what to do >>> without an explicit "Try -machine gic-version=host" h

Re: [PATCH] hw/intc/arm_gic_kvm: Don't assume kernel can provide a GICv2

2020-02-26 Thread Andrew Jones
On Wed, Feb 26, 2020 at 08:56:03AM +, Peter Maydell wrote: > On Wed, 26 Feb 2020 at 08:52, Andrew Jones wrote: > > Although, many QEMU command line users still won't know what to do > > without an explicit "Try -machine gic-version=host" hint, so that > > might be nice to add too. > > In the

Re: [PATCH] hw/intc/arm_gic_kvm: Don't assume kernel can provide a GICv2

2020-02-26 Thread Peter Maydell
On Wed, 26 Feb 2020 at 08:52, Andrew Jones wrote: > Although, many QEMU command line users still won't know what to do > without an explicit "Try -machine gic-version=host" hint, so that > might be nice to add too. In the GIC code we don't know if the machine even has a gic-version property, so w

Re: [PATCH] hw/intc/arm_gic_kvm: Don't assume kernel can provide a GICv2

2020-02-26 Thread Andrew Jones
On Tue, Feb 25, 2020 at 06:24:35PM +, Peter Maydell wrote: > In our KVM GICv2 realize function, we try to cope with old kernels > that don't provide the device control API (KVM_CAP_DEVICE_CTRL): we > try to use the device control, and if that fails we fall back to > assuming that the kernel has

Re: [PATCH] hw/intc/arm_gic_kvm: Don't assume kernel can provide a GICv2

2020-02-25 Thread Philippe Mathieu-Daudé
On 2/25/20 7:24 PM, Peter Maydell wrote: In our KVM GICv2 realize function, we try to cope with old kernels that don't provide the device control API (KVM_CAP_DEVICE_CTRL): we try to use the device control, and if that fails we fall back to assuming that the kernel has the old style KVM_CREATE_IR

[PATCH] hw/intc/arm_gic_kvm: Don't assume kernel can provide a GICv2

2020-02-25 Thread Peter Maydell
In our KVM GICv2 realize function, we try to cope with old kernels that don't provide the device control API (KVM_CAP_DEVICE_CTRL): we try to use the device control, and if that fails we fall back to assuming that the kernel has the old style KVM_CREATE_IRQCHIP and that it will provide a GICv2. Th