Re: [PATCH] hw/intc/allwinner-a10-pic: Don't use set_bit()/clear_bit()

2023-05-02 Thread Peter Maydell
On Mon, 24 Apr 2023 at 16:28, Peter Maydell wrote: > > The Allwinner PIC model uses set_bit() and clear_bit() to update the > values in its irq_pending[] array when an interrupt arrives. However > it is using these functions wrongly: they work on an array of type > 'long', and it is passing an ar

Re: [PATCH] hw/intc/allwinner-a10-pic: Don't use set_bit()/clear_bit()

2023-04-25 Thread Philippe Mathieu-Daudé
On 24/4/23 17:28, Peter Maydell wrote: The Allwinner PIC model uses set_bit() and clear_bit() to update the values in its irq_pending[] array when an interrupt arrives. However it is using these functions wrongly: they work on an array of type 'long', and it is passing an array of type 'uint32_t

Re: [PATCH] hw/intc/allwinner-a10-pic: Don't use set_bit()/clear_bit()

2023-04-24 Thread Thomas Huth
On 24/04/2023 17.28, Peter Maydell wrote: The Allwinner PIC model uses set_bit() and clear_bit() to update the values in its irq_pending[] array when an interrupt arrives. However it is using these functions wrongly: they work on an array of type 'long', and it is passing an array of type 'uint3

[PATCH] hw/intc/allwinner-a10-pic: Don't use set_bit()/clear_bit()

2023-04-24 Thread Peter Maydell
The Allwinner PIC model uses set_bit() and clear_bit() to update the values in its irq_pending[] array when an interrupt arrives. However it is using these functions wrongly: they work on an array of type 'long', and it is passing an array of type 'uint32_t'. Because the code manually figures out