Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-19 Thread Kevin Wolf
Am 18.05.2020 um 20:26 hat John Snow geschrieben: > > > On 5/15/20 4:48 AM, Kevin Wolf wrote: > > Am 14.05.2020 um 22:21 hat John Snow geschrieben: > >> > >> > >> On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote: > >>> Handlers don't need to modify the IDEDMA structure. > >>> Make it const. > >>

Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-18 Thread John Snow
On 5/15/20 4:48 AM, Kevin Wolf wrote: > Am 14.05.2020 um 22:21 hat John Snow geschrieben: >> >> >> On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote: >>> Handlers don't need to modify the IDEDMA structure. >>> Make it const. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >> >> I'll trust your jud

Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-15 Thread Kevin Wolf
Am 14.05.2020 um 22:21 hat John Snow geschrieben: > > > On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote: > > Handlers don't need to modify the IDEDMA structure. > > Make it const. > > > > Signed-off-by: Philippe Mathieu-Daudé > > I'll trust your judgment. As long as it still compiles and pa

Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/14/20 10:21 PM, John Snow wrote: On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote: Handlers don't need to modify the IDEDMA structure. Make it const. Signed-off-by: Philippe Mathieu-Daudé I'll trust your judgment. As long as it still compiles and passes qtests, I'm happy if you're hap

Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-14 Thread John Snow
On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote: > Handlers don't need to modify the IDEDMA structure. > Make it const. > > Signed-off-by: Philippe Mathieu-Daudé I'll trust your judgment. As long as it still compiles and passes qtests, I'm happy if you're happy. Acked-by: John Snow > ---

[PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-12 Thread Philippe Mathieu-Daudé
Handlers don't need to modify the IDEDMA structure. Make it const. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/internal.h | 12 ++-- hw/ide/ahci.c | 18 +- hw/ide/core.c | 6 +++--- hw/ide/macio.c| 6 +++--- hw/ide/pci.c