Re: [PATCH] hw/i386/intel_iommu: changes towards enabling -Wshadow=local

2023-10-03 Thread Ani Sinha
> On 03-Oct-2023, at 4:06 PM, Ani Sinha wrote: > > Code changes that addresses all compiler complaints coming from enabling > -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing > other local variables or parameters. These makes the code confusing and/or > adds > bugs

[PATCH] hw/i386/intel_iommu: changes towards enabling -Wshadow=local

2023-10-03 Thread Ani Sinha
Code changes that addresses all compiler complaints coming from enabling -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing other local variables or parameters. These makes the code confusing and/or adds bugs that are difficult to catch. See also Subject: Help wanted