[PATCH] hw/display/bcm2835_fb.c: Initialize all fields of struct

2020-10-12 Thread Peter Maydell
In bcm2835_fb_mbox_push(), Coverity complains (CID 1429989) that we pass a pointer to a local struct to another function without initializing all its fields. This is a real bug: bcm2835_fb_reconfigure() copies the whole of our new BCM2385FBConfig struct into s->config, so any fields we don't initi

Re: [PATCH] hw/display/bcm2835_fb.c: Initialize all fields of struct

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 9:54 PM, Peter Maydell wrote: > In bcm2835_fb_mbox_push(), Coverity complains (CID 1429989) that we > pass a pointer to a local struct to another function without > initializing all its fields. This is a real bug: > bcm2835_fb_reconfigure() copies the whole of our new BCM2385FBConfig >

[PATCH] hw/display/bcm2835_fb.c: Initialize all fields of struct

2020-06-28 Thread Peter Maydell
In bcm2835_fb_mbox_push(), Coverity complains (CID 1429989) that we pass a pointer to a local struct to another function without initializing all its fields. This is a real bug: bcm2835_fb_reconfigure() copies the whole of our new BCM2385FBConfig struct into s->config, so any fields we don't initi