Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-10-04 Thread Markus Armbruster
Jonathan Cameron writes: > Rename the version not burried in the macro to cap_h. > > Signed-off-by: Jonathan Cameron Queued, thanks!

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-10-03 Thread Fan Ni
On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > Rename the version not burried in the macro to cap_h. > > Signed-off-by: Jonathan Cameron > --- > > I had another instance of this in a series I'll post later today. > Cleaned that up the same way. > > hw/cxl/cxl-device-utils

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-10-03 Thread Fan Ni
On Fri, Sep 29, 2023 at 09:50:16AM +0200, Markus Armbruster wrote: > Jonathan Cameron writes: > > > On Wed, 27 Sep 2023 19:13:35 + > > Fan Ni wrote: > > > >> On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > >> > >> > Rename the version not burried in the macro to cap_h.

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-10-03 Thread Michael S. Tsirkin
On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > Rename the version not burried in the macro to cap_h. > > Signed-off-by: Jonathan Cameron > --- Reviewed-by: Michael S. Tsirkin pls merge with the rest of local shadowing things. > I had another instance of this in a serie

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-09-29 Thread Markus Armbruster
Jonathan Cameron writes: > On Wed, 27 Sep 2023 19:13:35 + > Fan Ni wrote: > >> On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: >> >> > Rename the version not burried in the macro to cap_h. >> The change looks good to me. Just one minor thing. why "version" get >> involve

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-09-28 Thread Jonathan Cameron via
On Wed, 27 Sep 2023 19:13:35 + Fan Ni wrote: > On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > > > Rename the version not burried in the macro to cap_h. > The change looks good to me. Just one minor thing. why "version" get > involved here? > Used in the sense of two c

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-09-27 Thread Fan Ni
On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > Rename the version not burried in the macro to cap_h. The change looks good to me. Just one minor thing. why "version" get involved here? Fan > > Signed-off-by: Jonathan Cameron > --- > > I had another instance of this in a se

[PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-09-25 Thread Jonathan Cameron via
Rename the version not burried in the macro to cap_h. Signed-off-by: Jonathan Cameron --- I had another instance of this in a series I'll post later today. Cleaned that up the same way. hw/cxl/cxl-device-utils.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/cxl