Re: [PATCH] hw/char/pl011: Use correct masks for IBRD and FBRD

2024-10-09 Thread Gavin Shan
On 10/8/24 12:47 AM, Peter Maydell wrote: In commit b88cfee90268cad we defined masks for the IBRD and FBRD integer and fractional baud rate divider registers, to prevent the guest from writing invalid values which could cause division-by-zero. Unfortunately we got the mask values the wrong way ar

Re: [PATCH] hw/char/pl011: Use correct masks for IBRD and FBRD

2024-10-07 Thread Philippe Mathieu-Daudé
On 7/10/24 11:47, Peter Maydell wrote: In commit b88cfee90268cad we defined masks for the IBRD and FBRD integer and fractional baud rate divider registers, to prevent the guest from writing invalid values which could cause division-by-zero. Unfortunately we got the mask values the wrong way aroun

Re: [PATCH] hw/char/pl011: Use correct masks for IBRD and FBRD

2024-10-07 Thread Alex Bennée
Peter Maydell writes: > In commit b88cfee90268cad we defined masks for the IBRD and FBRD > integer and fractional baud rate divider registers, to prevent the > guest from writing invalid values which could cause division-by-zero. > Unfortunately we got the mask values the wrong way around: the FB

[PATCH] hw/char/pl011: Use correct masks for IBRD and FBRD

2024-10-07 Thread Peter Maydell
In commit b88cfee90268cad we defined masks for the IBRD and FBRD integer and fractional baud rate divider registers, to prevent the guest from writing invalid values which could cause division-by-zero. Unfortunately we got the mask values the wrong way around: the FBRD register is six bits and the