Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-23 Thread Gavin Shan
On 2/21/20 8:46 PM, Philippe Mathieu-Daudé wrote: On 2/21/20 10:37 AM, Philippe Mathieu-Daudé wrote: Cc'ing Igor & Drew. On 2/21/20 7:28 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200221044908.266883-1-gs...@redhat.com/  > === TEST SCRIPT BEGIN === #!/bin/bash ma

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-21 Thread Philippe Mathieu-Daudé
On 2/21/20 10:37 AM, Philippe Mathieu-Daudé wrote: Cc'ing Igor & Drew. On 2/21/20 7:28 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200221044908.266883-1-gs...@redhat.com/ > === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make doc

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-21 Thread Philippe Mathieu-Daudé
Cc'ing Igor & Drew. On 2/21/20 7:28 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200221044908.266883-1-gs...@redhat.com/ > === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 ===

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-21 Thread Gavin Shan
On 2/21/20 7:25 PM, Paolo Bonzini wrote: On 21/02/20 05:49, Gavin Shan wrote: @@ -306,6 +362,7 @@ static const VMStateDescription vmstate_pl011 = { VMSTATE_UINT32(int_enabled, PL011State), VMSTATE_UINT32(int_level, PL011State), VMSTATE_UINT32_ARRAY(read_fifo, PL011S

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-21 Thread Paolo Bonzini
On 21/02/20 05:49, Gavin Shan wrote: > @@ -306,6 +362,7 @@ static const VMStateDescription vmstate_pl011 = { > VMSTATE_UINT32(int_enabled, PL011State), > VMSTATE_UINT32(int_level, PL011State), > VMSTATE_UINT32_ARRAY(read_fifo, PL011State, 16), > +VMSTATE_UINT8_ARR

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200221044908.266883-1-gs...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

[PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-20 Thread Gavin Shan
The depth of TxFIFO can be 1 or 16 depending on LCR[4]. The TxFIFO is disabled when its depth is 1. It's nice to have TxFIFO enabled if possible because more characters can be piled and transmitted at once, which would have less overhead. Besides, we can be blocked because of qemu_chr_fe_write_all(