Re: [PATCH] hw/block/nvme: fix for non-msix machines

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 10:46 AM, Klaus Jensen wrote: > On Jan 15 10:37, Philippe Mathieu-Daudé wrote: >> On 1/15/21 8:07 AM, Klaus Jensen wrote: >>> On Jan 12 14:20, Philippe Mathieu-Daudé wrote: On 1/12/21 1:47 PM, Klaus Jensen wrote: > From: Klaus Jensen > > Commit 1c0c2163aa08 ("hw/block/n

Re: [PATCH] hw/block/nvme: fix for non-msix machines

2021-01-15 Thread Klaus Jensen
On Jan 15 10:37, Philippe Mathieu-Daudé wrote: > On 1/15/21 8:07 AM, Klaus Jensen wrote: > > On Jan 12 14:20, Philippe Mathieu-Daudé wrote: > >> On 1/12/21 1:47 PM, Klaus Jensen wrote: > >>> From: Klaus Jensen > >>> > >>> Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() > >>>

Re: [PATCH] hw/block/nvme: fix for non-msix machines

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 8:07 AM, Klaus Jensen wrote: > On Jan 12 14:20, Philippe Mathieu-Daudé wrote: >> On 1/12/21 1:47 PM, Klaus Jensen wrote: >>> From: Klaus Jensen >>> >>> Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() >>> return value") had the unintended effect of breaking support

Re: [PATCH] hw/block/nvme: fix for non-msix machines

2021-01-14 Thread Klaus Jensen
On Jan 12 14:20, Philippe Mathieu-Daudé wrote: > On 1/12/21 1:47 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() > > return value") had the unintended effect of breaking support on > > several platforms not supporting MS

Re: [PATCH] hw/block/nvme: fix for non-msix machines

2021-01-12 Thread Philippe Mathieu-Daudé
On 1/12/21 1:47 PM, Klaus Jensen wrote: > From: Klaus Jensen > > Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() > return value") had the unintended effect of breaking support on > several platforms not supporting MSI-X. > > Still check for errors, but only report that MSI-

[PATCH] hw/block/nvme: fix for non-msix machines

2021-01-12 Thread Klaus Jensen
From: Klaus Jensen Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() return value") had the unintended effect of breaking support on several platforms not supporting MSI-X. Still check for errors, but only report that MSI-X is unsupported instead of bailing out. Reported-by: