Re: [PATCH] hw/audio/sb16: Do not migrate qdev properties

2024-01-05 Thread Philippe Mathieu-Daudé
On 5/1/24 02:59, Peter Xu wrote: On Thu, Jan 04, 2024 at 05:48:18PM +0100, Philippe Mathieu-Daudé wrote: If there are no objections I'll queue this patch (fixing the typo reported by Zoltan). Yes feel free to. Thanks, Thanks, merged as commit fa293f8125.

Re: [PATCH] hw/audio/sb16: Do not migrate qdev properties

2024-01-04 Thread Peter Xu
On Thu, Jan 04, 2024 at 05:48:18PM +0100, Philippe Mathieu-Daudé wrote: > If there are no objections I'll queue this patch (fixing > the typo reported by Zoltan). Yes feel free to. Thanks, -- Peter Xu

Re: [PATCH] hw/audio/sb16: Do not migrate qdev properties

2024-01-04 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > If there are no objections I'll queue this patch (fixing > the typo reported by Zoltan). > > On 24/11/23 19:26, Philippe Mathieu-Daudé wrote: >> Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these >> fields has been converted to qdev properties, so do

Re: [PATCH] hw/audio/sb16: Do not migrate qdev properties

2024-01-04 Thread Philippe Mathieu-Daudé
If there are no objections I'll queue this patch (fixing the typo reported by Zoltan). On 24/11/23 19:26, Philippe Mathieu-Daudé wrote: Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these fields has been converted to qdev properties, so don't need to be migrated: static Property

Re: [PATCH] hw/audio/sb16: Do not migrate qdev properties

2023-12-13 Thread BALATON Zoltan
On Wed, 13 Dec 2023, Philippe Mathieu-Daudé wrote: ping? On 24/11/23 19:26, Philippe Mathieu-Daudé wrote: Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these fields has been converted to qdev properties, so don't need to be Typo: fields have been migrated: static Property s

Re: [PATCH] hw/audio/sb16: Do not migrate qdev properties

2023-12-13 Thread Philippe Mathieu-Daudé
ping? On 24/11/23 19:26, Philippe Mathieu-Daudé wrote: Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these fields has been converted to qdev properties, so don't need to be migrated: static Property sb16_properties[] = { DEFINE_AUDIO_PROPERTIES(SB16State, card), DE

[PATCH] hw/audio/sb16: Do not migrate qdev properties

2023-11-24 Thread Philippe Mathieu-Daudé
Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these fields has been converted to qdev properties, so don't need to be migrated: static Property sb16_properties[] = { DEFINE_AUDIO_PROPERTIES(SB16State, card), DEFINE_PROP_UINT32 ("version", SB16State, ver, 0x0405), /* 4.5