Re: [PATCH] hw/audio/hda: avoid unnecessary re-open stream on reconfiguration

2024-11-14 Thread Peter Maydell
On Thu, 14 Nov 2024 at 12:57, Marc-André Lureau wrote: > > Hi Paolo > > Did you see that patch? What do you say about it? I think Paolo's patch seems like a cleaner fix for the leak than this one. Incidentally, to recap something I said on IRC: it seems to me like part of the problem here is tha

Re: [PATCH] hw/audio/hda: avoid unnecessary re-open stream on reconfiguration

2024-11-14 Thread Paolo Bonzini
On 11/5/24 09:32, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Closing and opening a stream too quickly during reconfiguration create issues with Spice. Note: the issue with Spice has been there before and still is. When the audio stream is recreated, for example when using `out.

Re: [PATCH] hw/audio/hda: avoid unnecessary re-open stream on reconfiguration

2024-11-14 Thread Marc-André Lureau
Hi Paolo Did you see that patch? What do you say about it? On Tue, Nov 5, 2024 at 12:33 PM wrote: > From: Marc-André Lureau > > Closing and opening a stream too quickly during reconfiguration create > issues with Spice. > > Note: the issue with Spice has been there before and still is. When th

[PATCH] hw/audio/hda: avoid unnecessary re-open stream on reconfiguration

2024-11-05 Thread marcandre . lureau
From: Marc-André Lureau Closing and opening a stream too quickly during reconfiguration create issues with Spice. Note: the issue with Spice has been there before and still is. When the audio stream is recreated, for example when using `out.mixing-engine=false`. Fixes: https://gitlab.com/qemu-p