Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Philippe Mathieu-Daudé
On 6/18/20 12:23 PM, Peter Maydell wrote: > On Thu, 18 Jun 2020 at 11:22, Philippe Mathieu-Daudé > wrote: >> >> On 6/17/20 10:23 PM, Peter Maydell wrote: >>> On Mon, 15 Jun 2020 at 22:23, Allan Peramaki wrote: Fix audio on software that accesses DRAM above 64k via register peek/poke >>

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Peter Maydell
On Thu, 18 Jun 2020 at 11:22, Philippe Mathieu-Daudé wrote: > > On 6/17/20 10:23 PM, Peter Maydell wrote: > > On Mon, 15 Jun 2020 at 22:23, Allan Peramaki wrote: > >> > >> Fix audio on software that accesses DRAM above 64k via register peek/poke > >> and some cases when more than 16 voices are us

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Philippe Mathieu-Daudé
On 6/17/20 10:23 PM, Peter Maydell wrote: > On Mon, 15 Jun 2020 at 22:23, Allan Peramaki wrote: >> >> Fix audio on software that accesses DRAM above 64k via register peek/poke >> and some cases when more than 16 voices are used. >> >> Fixes: 135f5ae1974c ("audio: GUSsample is int16_t") >> Signed-o

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Peter Maydell
On Wed, 17 Jun 2020 at 23:26, Allan Peramaki wrote: > > On 17/06/2020 23:23, Peter Maydell wrote: > > > > This patch is quite difficult to read because it mixes some > > whitespace only changes with some actual changes of > > behaviour. > > Sorry about that. I had to put some whitespace in the two

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-17 Thread Thomas Huth
On 18/06/2020 00.25, Allan Peramaki wrote: > On 17/06/2020 23:23, Peter Maydell wrote: >> >> This patch is quite difficult to read because it mixes some >> whitespace only changes with some actual changes of >> behaviour. > > Sorry about that. I had to put some whitespace in the two lines I > modi

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-17 Thread Thomas Huth
On 15/06/2020 22.17, Allan Peramaki wrote: > Fix audio on software that accesses DRAM above 64k via register peek/poke > and some cases when more than 16 voices are used. > > Fixes: 135f5ae1974c ("audio: GUSsample is int16_t") > Signed-off-by: Allan Peramaki > --- > hw/audio/gusemu_hal.c | 6 +

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-17 Thread Allan Peramaki
On 18/06/2020 01:25, Allan Peramaki wrote: On 17/06/2020 23:23, Peter Maydell wrote: Are these accesses all guaranteed to be correctly aligned to be 16 or 32 bit loads/stores ? Otherwise it would be better to use the ldl_p/stl_p/ldw_p/stw_p/etc accessors, which correctly handle possibly misalign

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-17 Thread Allan Peramaki
On 17/06/2020 23:23, Peter Maydell wrote: This patch is quite difficult to read because it mixes some whitespace only changes with some actual changes of behaviour. Sorry about that. I had to put some whitespace in the two lines I modified because of checkpatch.pl, but then the nearby lines w

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-17 Thread Peter Maydell
On Mon, 15 Jun 2020 at 22:23, Allan Peramaki wrote: > > Fix audio on software that accesses DRAM above 64k via register peek/poke > and some cases when more than 16 voices are used. > > Fixes: 135f5ae1974c ("audio: GUSsample is int16_t") > Signed-off-by: Allan Peramaki This patch is quite diffic

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-17 Thread Volker Rümelin
> Fix audio on software that accesses DRAM above 64k via register peek/poke > and some cases when more than 16 voices are used. > > Fixes: 135f5ae1974c ("audio: GUSsample is int16_t") > Signed-off-by: Allan Peramaki > --- > hw/audio/gusemu_hal.c | 6 +++--- > hw/audio/gusemu_mixer.c | 8 ---

[PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-15 Thread Allan Peramaki
Fix audio on software that accesses DRAM above 64k via register peek/poke and some cases when more than 16 voices are used. Fixes: 135f5ae1974c ("audio: GUSsample is int16_t") Signed-off-by: Allan Peramaki --- hw/audio/gusemu_hal.c | 6 +++--- hw/audio/gusemu_mixer.c | 8 2 files chan